mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Kees Cook" <kees@kernel.org>,
	"Kees Cook" <kees+treewide@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Stanley Chang" <stanley_chang@realtek.com>,
	"Johan Hovold" <johan+linaro@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Jinjie Ruan" <ruanjinjie@huawei.com>,
	"Rob Herring" <robh@kernel.org>,
	"Charles Han" <hanchunchao@inspur.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] phy: realtek: usb: Remove const from phy_cfg allocation type
Date: Thu, 17 Sep 2026 14:13:04 -0700	[thread overview]
Message-ID: <20260917211303.i.538-kees@kernel.org> (raw)

From: Kees Cook <kees+treewide@kernel.org>

In preparation for making the devm_kmalloc family of allocators type
aware, we need to make sure that the returned type from the allocation
matches the type of the variable being assigned. (Before, the allocator
would always return "void *", which can be implicitly cast to any
pointer type.)

In both the USB2 and USB3 PHY drivers, the assigned type is
"struct phy_cfg *", but the converted allocation type would be
"const struct phy_cfg *", as the size was taken from the local
"phy_cfg", which points to const as it comes from
of_device_get_match_data(). As there is no general way to remove const
qualifiers, take the size from the assignment target instead. No change
in allocation size results.

Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
drivers/phy/realtek/phy-rtk-usb2.o
drivers/phy/realtek/phy-rtk-usb3.o

Assisted-by: LLM coccinelle
Signed-off-by: Kees Cook <kees+treewide@kernel.org>
---
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stanley Chang <stanley_chang@realtek.com>
Cc: Johan Hovold <johan+linaro@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Charles Han <hanchunchao@inspur.com>
Cc: <linux-phy@lists.infradead.org>
---
 drivers/phy/realtek/phy-rtk-usb2.c | 3 ++-
 drivers/phy/realtek/phy-rtk-usb3.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/realtek/phy-rtk-usb2.c b/drivers/phy/realtek/phy-rtk-usb2.c
index 248550ef98ca..1f08b151d90a 100644
--- a/drivers/phy/realtek/phy-rtk-usb2.c
+++ b/drivers/phy/realtek/phy-rtk-usb2.c
@@ -1022,7 +1022,8 @@ static int rtk_usb2phy_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	rtk_phy->dev			= &pdev->dev;
-	rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*phy_cfg), GFP_KERNEL);
+	rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*rtk_phy->phy_cfg),
+					GFP_KERNEL);
 	if (!rtk_phy->phy_cfg)
 		return -ENOMEM;
 
diff --git a/drivers/phy/realtek/phy-rtk-usb3.c b/drivers/phy/realtek/phy-rtk-usb3.c
index cce453686db2..4231a8aa0ba5 100644
--- a/drivers/phy/realtek/phy-rtk-usb3.c
+++ b/drivers/phy/realtek/phy-rtk-usb3.c
@@ -576,7 +576,8 @@ static int rtk_usb3phy_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	rtk_phy->dev			= &pdev->dev;
-	rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*phy_cfg), GFP_KERNEL);
+	rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*rtk_phy->phy_cfg),
+					GFP_KERNEL);
 	if (!rtk_phy->phy_cfg)
 		return -ENOMEM;
 
-- 
2.34.1


                 reply	other threads:[~2026-09-17 21:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917211303.i.538-kees@kernel.org \
    --to=kees@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanchunchao@inspur.com \
    --cc=johan+linaro@kernel.org \
    --cc=kees+treewide@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=stanley_chang@realtek.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®