mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liang Haowen <nbg2974@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH RFC v6 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures
Date: Thu, 17 Sep 2026 11:49:18 -0000	[thread overview]
Message-ID: <202609172115.ReplyLeeR6.lhw@gmail.com> (raw)
In-Reply-To: <20260917112840.GJ1605367@google.com>

This one is the same false positive as in every round so far:
kzalloc_obj() has been in include/linux/slab.h since v7.0 (line 1152
in the 7.2.4 tree this driver builds against), so the bot's reference
tree simply predates it. Nothing to fix.

I considered switching to plain kzalloc() to end the loop, but
checkpatch on 7.2.4 flags that form with "Prefer kzalloc_obj over
kzalloc with sizeof", so the two tools disagree and I would rather
keep the checkpatch-clean one. Happy to switch if you prefer
kzalloc().

Both questions from the v6 cover letter are still open, by the way:
whether deferring the Kconfig/Makefile/MAINTAINERS wiring to the
agreed SCSI transport split is acceptable for an RFC, and whether
"led" should become a LED_FUNCTION_* value or the plain ordinal
function is fine.

  parent reply	other threads:[~2026-09-17 11:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 14:26 [PATCH RFC 0/1] leds: add ASUS Aura SCSI " Liang Haowen
2026-09-01 14:34 ` [PATCH RFC 1/1] " Liang Haowen
2026-09-03 12:00   ` [PATCH RFC v2 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED " Liang Haowen
     [not found]     ` <20260903161357.GX2133376@google.com>
2026-09-04 12:30       ` [PATCH RFC v3 0/1] " Liang Haowen
2026-09-04 12:30         ` [PATCH RFC v3 1/1] " Liang Haowen
     [not found]           ` <20260904131503.355C41F00A3E@smtp.kernel.org>
     [not found]             ` <20260910093232.GO2133376@google.com>
2026-09-15 12:48               ` [PATCH RFC v4 0/1] " Liang Haowen
2026-09-15 12:49                 ` [PATCH RFC v4 1/1] " Liang Haowen
     [not found]                   ` <20260915130050.E8CDB1F000FF@smtp.kernel.org>
     [not found]                     ` <20260916104305.GM11487@google.com>
2026-09-16 12:15                       ` [PATCH RFC v5 0/1] " Liang Haowen
2026-09-16 12:15                         ` [PATCH RFC v5 1/1] " Liang Haowen
     [not found]                           ` <20260916122740.921E51F000FF@smtp.kernel.org>
     [not found]                             ` <20260916130602.GS11487@google.com>
2026-09-16 14:22                               ` [PATCH RFC v6 0/1] " Liang Haowen
2026-09-16 14:22                                 ` [PATCH RFC v6 1/1] " Liang Haowen
     [not found]                                   ` <20260916143832.520721F000FF@smtp.kernel.org>
     [not found]                                     ` <20260917112840.GJ1605367@google.com>
2026-09-17 11:49                                       ` Liang Haowen [this message]
2026-09-16 14:23                               ` [PATCH RFC v5 " Liang Haowen
2026-09-16 12:15                       ` [PATCH RFC v4 " Liang Haowen
2026-09-15 12:49               ` [PATCH RFC v3 " Liang Haowen
2026-09-03 12:00   ` [PATCH RFC v2 0/1] " Liang Haowen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609172115.ReplyLeeR6.lhw@gmail.com \
    --to=nbg2974@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®