mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	leoreis.costa@gmail.com, fra.schnyder@gmail.com,
	francesco@dolcini.it, frank.li@nxp.com, l.stach@pengutronix.de,
	lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	robh@kernel.org, bhelgaas@google.com, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	hongxing.zhu@oss.nxp.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, Richard Zhu <hongxing.zhu@nxp.com>,
	stable@vger.kernel.org,
	Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH v2] PCI: imx6: Move clock enable after core reset assertion
Date: Thu, 17 Sep 2026 16:58:02 -0500	[thread overview]
Message-ID: <20260917215802.GA1056201@bhelgaas> (raw)
In-Reply-To: <7ed9e4de-2e57-4c15-875c-16512f00163f@leemhuis.info>

On Thu, Sep 17, 2026 at 01:08:03PM +0200, Thorsten Leemhuis wrote:
> On 9/2/26 16:15, Manivannan Sadhasivam wrote:
> > On Thu, 13 Aug 2026 17:50:03 +0800, hongxing.zhu@oss.nxp.com wrote:
> >> Commit 610fa91d9863 ("PCI: imx6: Assert PERST# before enabling regulators")
> >> inadvertently moved clock enablement before core reset assertion, breaking
> >> PCI device initialization on i.MX6Q Apalis platforms with
> >> ASM1061/ASM1062 SATA controllers connected.
> >>
> >> NOTE: It is not 100% clear if the issue is specific to the ASM1061/ASM1062
> >> device or on the specific power-up sequence (reset vs cold-power-on).
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> > [1/1] PCI: imx6: Move clock enable after core reset assertion
> >       commit: 16929741a622eb345057e41c7b335d9b297890e1
> Thx Mani.
> 
> Mani, Bjorn, what's the status of this patch? Is it heading to mainline
> any time soon? This (unless I got confused, which is possible!) afaics
> fixes a 7.2 regression that annoyed quite a few people -- which is why
> it was even briefly considered to revert about a Dozent changes shortly
> before the 7.2 final:
> https://lore.kernel.org/all/20260811214900.GA763236@bhelgaas/
> 
> Didn't come to this, but it afaics would be good to finally resolve
> this. Or am I missing/confused something?

It's in pci/next, but probably should be in for-linus.

I moved it to pci/for-linus for v7.3, thanks for the heads-up.

      reply	other threads:[~2026-09-17 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  9:50 hongxing.zhu
2026-08-31  9:30 ` Francesco Dolcini
2026-09-02 14:15 ` Manivannan Sadhasivam
2026-09-17 11:08   ` Thorsten Leemhuis
2026-09-17 21:58     ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917215802.GA1056201@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=festevam@gmail.com \
    --cc=fra.schnyder@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=frank.li@nxp.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=hongxing.zhu@oss.nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kwilczynski@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=leoreis.costa@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®