From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E7A415B92; Fri, 18 Sep 2026 10:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789728114; cv=none; b=iEb//lcDKx3qtZ3r4Cme5jy5QMwpku+CvAkwQpTL2TSaUCv5UcIILvf4kfrFj/QE9raJKWP3EsVLGQHuA0EcM4p4jhq5MzhwqUDDaArc+Ae8efWMIX2RYf3BvPds+vdHAWbzaAN756lWOyBMj87utz1OG6MXk6XMkuMfNJnXTlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789728114; c=relaxed/simple; bh=rl84C4ONuIM6uvedwccwpsIKbrFWDQorasJcY+NMHR0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=oA3zPzAme1ghLdSl5apphau3ACs4/WGcFptt97PmWxE3aOF/QEnYvP215qygFsiNoWvm+TaNEF1kKoDPxxxnS4QE7eWLVpq2Px9I4gGF5g6BpXodEgX1H2hSvfiyEz2j+QgQovcvDKwsy5tSk54sJqtIP9jpp+z8BUhdU4tBryI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=OUzBpx/f; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="OUzBpx/f" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9ddEN2867218; Fri, 18 Sep 2026 11:41:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=W FZDtpGn0hp1sx5qqrvhGry+sbXQlcx/KuBrsyBaufo=; b=OUzBpx/fVqzctSxa2 vkWOPd7A72A2cHNOSNgFucNavOdjDDweQJiT9YnVpotPPP5wRFS0/jODSIeN+3U+ JbIdGIxJ97t4Kn0xmKoD3i5NaPj3bBOhoiO/anpAsiut1NTovePU8om3tImU79tC poNE9mvUz3bx37ccJnxe4eD0t4+k7QTSz9GgSgKREjEa/gcm+GfgwXsRg9Tq9tCf W3sw5EyFr6U8TUTyHduB805ldMJrdBwmueMftIkBR5xLPHOrhvS0fyL0uhTerXBa YyzBsH9KjA+eKsNmIUF1WVwwMiiWzPN2rQzffE+GQ5c9gL4t7BNMFk2Vrq2yIgjU hvNTw== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4gmw0q4ysn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 11:41:32 +0100 (BST) Received: from [127.0.1.1] (172.25.128.225) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Fri, 18 Sep 2026 11:41:28 +0100 From: Brajesh Gupta Date: Fri, 18 Sep 2026 16:11:13 +0530 Subject: [PATCH v3 1/2] drm/imagination: Propagate map failures correctly from pvr_mmu_map_sgl() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260918-mmu_fix-v3-1-7b3d73aef041@imgtec.com> References: <20260918-mmu_fix-v3-0-7b3d73aef041@imgtec.com> In-Reply-To: <20260918-mmu_fix-v3-0-7b3d73aef041@imgtec.com> To: Alessio Belle , Luigi Santivetti , Frank Binns , Alexandru Dadu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , , Brajesh Gupta X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4877; i=brajesh.gupta@imgtec.com; h=from:subject:message-id; bh=rl84C4ONuIM6uvedwccwpsIKbrFWDQorasJcY+NMHR0=; b=owEBbQKS/ZANAwAKAdAmd1l+AvFwAcsmYgBqrRVT0lTuMbmKXiXhUkzoG/Lz59pJFnv6aLx/H LaXw3iG+NGJAjMEAAEKAB0WIQSQIkZAwD1cxcAsz3LQJndZfgLxcAUCaq0VUwAKCRDQJndZfgLx cHxgEADNxkalTc2ecg5QLb7rfw56qeTKxOuZzPEZDvEwOBMFZmkuUkREranotllF2ZJ2fNzTCr0 Gpx+2hgkDHMGSmmIzKo35SP84cKONPY/ELF8qNlGbnBMNllw3RkN6pSOV96+b5j9JJPUy+t8CN8 BTRUzO4lfY+U+QQzj6AQWPTRpAUWIUIg9WP0ogrbKJP2lGx6pELTLR2YjA6sj5BNq5ZhBeDUigL SaolUVlkrOTsh8pB/2O856a9cPMWz5GS+io6Vxc6WaspqoT+28F267CvwkH4nnoUSOZPpfTmwGL pspHCvSnCYBpsZS/OpupPwwMZb8Y475N1qdr1VOIA7QkrV2hvK30Tvlfbcr2Gmy7l3p1GrGzH6D VNnnWR11+t8ssGtl2hc0Ed7LvWx6xq6HG16MimsDiGdb4VU8sEqhdHtx8XUVuXBy4fGYmJMTZrX bvxgrs/8fFf3hxRXNQMu/DVzGLs+gFIyCXK7PiijMVVdROv5R/4trmLBQGZgVwh38FFm7MIhFl6 qNM0EHQHvqy+MjpwwYJ/Z3GOdhIR4WTwg57Rgzjmq5tKXM5Q1L6O+CuWimctIK5CBVelAHamVMw LY315a2llc8VOzGQFFHCvpitZOInJAfmUoFb64OYXKc58j2z7xxsY+dx7/va2hVY76SJTJYAvul zNBJqXiN1SHl4qg== X-Developer-Key: i=brajesh.gupta@imgtec.com; a=openpgp; fpr=05BAA300FD5C580EFD3F8D2F073292BAD0D39671 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE0OSBTYWx0ZWRfX7PJwjtISwIsT BzJEvIs4TdMyMiwGm3QxR3j8+UxiurHJUNLcjOVNF/Un443hSL2ebkY5ZoPVOxgmNLZX41yGw8A lWsCitJrD048nCeUQoRvMHA7J3fqvPWE9vp3//cBa9GeX0b9g/KjxCiUW9ud/NKJdfMv2ZNeyV3 T5Bi9oOffwoEpqu11goy5MVchA79hzikdSDDrzfjs9Wxh7S3jpgkeMae2lDZd15rrFUE3NrUs6n gTOwZbZ5P7DWgb0vNoUW+MJccMOhikEoS3uu0yKfdsxxXTU70Fs7I4uAr+xfRRuzPuSwGWhc1Pa y41y7BrnFyPwLFMj/HOHKPQuYrHW9nyf6SzFJ83Ci+qK/ssNByaiP0wMyVDO2a7cJJ3Fc1f+WEo yQoa8Juukiu0UC8X2xiZ7byU0tYv+cc1hE4jzsAE1IHNCsv7IPPxYUVOBxs4prVEJtECWAjBqD/ 7CS3PWBG9uPaNI0Hfkg== X-Authority-Analysis: v=2.4 cv=c8M+0h9l c=1 sm=1 tr=0 ts=6aad155c cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=HYrZrZQ_E1YA:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=r_1tXGB3AAAA:8 a=MA1SxRKIldkD5NN-sdEA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: djoCe916n0ZA6tM_RbmTyOx_0skWeDoO X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE0OSBTYWx0ZWRfX9FTaaUHmF9Zp g45JOzMOOVnGM2hcrngS3Wo36jo7YyQpOTeE7Q6+XKvauGsl0y9HAn7sMxxKnZ1Gwm87YzqwzUL VQhZFGLP4i+DBTYQlzP1Neh4Y0AFJo8= X-Proofpoint-GUID: djoCe916n0ZA6tM_RbmTyOx_0skWeDoO Map failure from pvr_mmu_map_sgl() interface was not returned correctly to pvr_mmu_map() interface. This resulted in pvr_mmu_map() interface to continue instead of returning an error to caller. Fix it by returning a proper error code from pvr_mmu_map_sgl() interface. Call stack for crash: [ 1179.286237] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 [ 1179.295067] Mem abort info: [ 1179.297877] ESR = 0x0000000096000004 [ 1179.301656] EC = 0x25: DABT (current EL), IL = 32 bits [ 1179.306987] SET = 0, FnV = 0 [ 1179.310048] EA = 0, S1PTW = 0 [ 1179.313198] FSC = 0x04: level 0 translation fault [ 1179.318096] Data abort info: [ 1179.320993] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 [ 1179.326483] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 1179.331546] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 1179.336895] user pgtable: 4k pages, 48-bit VAs, pgdp=000000009822a000 [ 1179.343402] [0000000000000008] pgd=0000000000000000, p4d=0000000000000000 [ 1179.350243] Internal error: Oops: 0000000096000004 [#2] SMP [ 1179.355908] Modules linked in: powervr gpu_sched drm_shmem_helper drm_gpuvm drm_exec xhci_plat_hcd xhci_hcd dwc3 usbcore usb_common snd_soc_simple_card snd_soc_simple_card_utils dwc3_am62 at24 sa2ul sha512 libsha512 sha256 authenc sch_fq_codel fuse dm_mod ipv6 [ 1179.378992] CPU: 1 UID: 1000 PID: 680 Comm: deqp-vk Tainted: G D 6.17.0 #1 PREEMPT [ 1179.388120] Tainted: [D]=DIE [ 1179.390994] Hardware name: Texas Instruments AM625 SK (DT) [ 1179.396467] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 1179.403415] pc : pvr_mmu_op_context_unmap_curr_page+0x6c/0x134 [powervr] [ 1179.410140] lr : pvr_mmu_op_context_unmap_curr_page+0x58/0x134 [powervr] [ 1179.416848] sp : ffff8000839ab8c0 [ 1179.420153] x29: ffff8000839ab8c0 x28: 0000000000000001 x27: 000000008f386000 [ 1179.427283] x26: ffff000016d1df98 x25: 0000000000247000 x24: 00000000000001e6 [ 1179.434413] x23: 0000000000000002 x22: 000000000000ffff x21: 0000000000000247 [ 1179.441540] x20: 0000000000000245 x19: ffff000016d1df60 x18: 0000000000000002 [ 1179.448668] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000001 [ 1179.455793] x14: 0000000000060810 x13: ffff80007fffffff x12: ffff000004190480 [ 1179.462921] x11: ffff8000853f7000 x10: ffff8000811ae000 x9 : ffff0000041900b8 [ 1179.470051] x8 : 0000000000000000 x7 : 00000000990c4001 x6 : 0000000000000007 [ 1179.477177] x5 : ffff000016d1df60 x4 : 0000000000000000 x3 : ffff00000a7d8000 [ 1179.484306] x2 : 00000000000001ff x1 : 0000000000000000 x0 : 0000000000000000 [ 1179.491433] Call trace: [ 1179.493872] pvr_mmu_op_context_unmap_curr_page+0x6c/0x134 [powervr] (P) [ 1179.500582] pvr_mmu_map+0x31c/0x388 [powervr] [ 1179.505027] pvr_vm_gpuva_map+0x40/0x88 [powervr] [ 1179.509732] __drm_gpuvm_sm_map+0x250/0x44c [drm_gpuvm] [ 1179.514952] drm_gpuvm_sm_map+0x48/0x5c [drm_gpuvm] [ 1179.519822] pvr_vm_bind_op_exec+0x64/0x70 [powervr] [ 1179.524785] pvr_vm_map+0x1f8/0x2a8 [powervr] [ 1179.529142] pvr_ioctl_vm_map+0x12c/0x188 [powervr] [ 1179.534018] drm_ioctl_kernel+0xb8/0x128 [ 1179.537941] drm_ioctl+0x21c/0x4ec [ 1179.541337] __arm64_sys_ioctl+0xac/0x108 [ 1179.545344] invoke_syscall+0x44/0x100 [ 1179.549091] el0_svc_common.constprop.0+0x40/0xe0 [ 1179.553790] do_el0_svc+0x1c/0x28 [ 1179.557106] el0_svc+0x34/0xf0 [ 1179.560159] el0t_64_sync_handler+0xd0/0xe4 [ 1179.564334] el0t_64_sync+0x198/0x19c [ 1179.567996] Code: 54000300 35000360 f9402261 79409a62 (f9400421) [ 1179.574081] ---[ end trace 0000000000000000 ]--- Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code") Signed-off-by: Brajesh Gupta Reviewed-by: Alexandru Dadu Reviewed-by: Alessio Belle --- drivers/gpu/drm/imagination/pvr_mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_mmu.c b/drivers/gpu/drm/imagination/pvr_mmu.c index 3cac482e1034..23261d9ad3fd 100644 --- a/drivers/gpu/drm/imagination/pvr_mmu.c +++ b/drivers/gpu/drm/imagination/pvr_mmu.c @@ -12,6 +12,7 @@ #include "pvr_rogue_mmu_defs.h" #include +#include #include #include #include @@ -2553,7 +2554,9 @@ pvr_mmu_map_sgl(struct pvr_mmu_op_context *op_ctx, struct scatterlist *sgl, err_destroy_pages: memcpy(&op_ctx->curr_page, &ptr_copy, sizeof(op_ctx->curr_page)); - err = pvr_mmu_op_context_unmap_curr_page(op_ctx, page); + if (pvr_mmu_op_context_unmap_curr_page(op_ctx, page)) + drm_err(from_pvr_device(op_ctx->mmu_ctx->pvr_dev), + "%s : Failure in unmapping pages\n", __func__); return err; } -- 2.43.0