Re: [PATCH 1/3] dt-bindings: embedded-controller: Add ASUS Zenbook A16 EC

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Sep 17, 2026 at 12:54:56PM +0200, Konrad Dybcio wrote:
> +description:
> +  The Qualcomm Snapdragon X2 series-based ASUS Zenbook A16 (and similar
> +  machines) come with a custom EC firmware, loosely based on the
> +  Qualcomm reference ("Hamoa CRD EC") implementation, with a lot of
> +  customization.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - asus,zenbook-a14-ux3407na-ec
> +      - asus,zenbook-a16-ux3607oa-ec
> +
> +  reg:
> +    const: 0x76
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +
> +  wakeup-source: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - '#thermal-sensor-cells'
> +  - wakeup-source

Wakeup source should not be required. If it is, then it is completely
implied by compatible and there is no need for DT property, right?

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@76 {
> +          compatible = "asus,zenbook-a16-ux3607oa-ec";

Messed/mixed up indentation. Use 4 spaces.

Best regards,
Krzysztof