From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: devicetree@vger.kernel.org, frowand.list@gmail.com,
linux-kernel@vger.kernel.org, robh@kernel.org,
saravanak@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] of: unittest: Fix of_symbols reference leak in of_unittest_overlay_high_level()
Date: Fri, 18 Sep 2026 13:41:01 +0200 [thread overview]
Message-ID: <20260918-transparent-normal-spider-b2c565@quoll> (raw)
In-Reply-To: <20260917125717.2152371-1-vulab@iscas.ac.cn>
On Thu, Sep 17, 2026 at 12:57:17PM +0000, Wentao Liang wrote:
> of_get_child_by_name() returns a node with an elevated reference count,
> but the function never drops it: neither on the early return for an
> illegal node name, nor on the normal return, nor on the err_unlock
> path. Add the missing of_node_put() calls.
>
> Fixes: 81d0848fc8d2 ("of: Add unit tests for applying overlays")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Why are you sending 10 separate patches, one by one, not a proper
patchset? It's the same as with Guangshuo Li.
Look:
https://lore.kernel.org/all/?q=f%3AWentao+Liang+%3Cvulab%40iscas.ac.cn%3E
Absolutely nothing is threaded. No way for a subsystem maintainer to for
example drop one comment for entire subsystem. Instead you ask
maintainer to reply TO EACH of the patches.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-18 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 12:57 Wentao Liang
2026-09-18 11:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918-transparent-normal-spider-b2c565@quoll \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®