From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED0A38F233; Fri, 18 Sep 2026 01:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789694940; cv=none; b=cubj8V0v2bd5GLocWG4E0mNbvptS1oeCPkBXFAo9CAMbKz7jgjGe85sP/yF+NhymJLl3UqWq+YmeDCMQ5WGmmNGlfYd5r1X2OJ21gk8Vip4WzS5rIfg99ffsVSx9DGDpfaKgPnmm7/zspeQYlp6N27Y7hKj6kO7Lpec/iZnaVus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789694940; c=relaxed/simple; bh=r2wb3vrsQzTnLpySrB3l2Zf678BNuRe+z38ynKuL/3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LmpEygJyGLdE2WmOmemXtDHr12BhEk9D3Iuy7aCsH5QHqc/fMTErFiXo84AS4JPSlDcI93pTpEERiCDeX0U2OBvDnllJc0wqmWKPOv1trrKVE4gkG3x9dqWEImkMPJnPUh1Bit+IHNmLUoIW/HNSbKngdFZ+WM8T0V9UKAvn71Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=A55hI1Cr; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="A55hI1Cr" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 202524DC; Fri, 18 Sep 2026 03:27:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789694834; bh=r2wb3vrsQzTnLpySrB3l2Zf678BNuRe+z38ynKuL/3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A55hI1CrqpCZyKWZC3zKAArpORIZOW8IyOuISbQNcprB8NEPq837EFUkXQNQ8CUNV j/1rvYT9Y55WTq+ldgzv8wR8OBZNp4nY9c3VqFEjnT4o0aLKPz6jRKmsYmbbj4Cwat 2XJkbM/UG7cGhMl2EXZwDBJYsJARaBlX54DI7Kx8= Date: Fri, 18 Sep 2026 04:28:55 +0300 From: Laurent Pinchart To: Paul Elder Cc: Geert Uytterhoeven , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Ulf Hansson , Mauro Carvalho Chehab , Philipp Zabel , Kieran Bingham , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 07/10] media: rcar-fcp: Handle resets Message-ID: <20260918012855.GG145152@killaraus.ideasonboard.com> References: <20260917-epaul-v7-3-rc1-x5h-vsp-fcp-v1-0-4c72d4e086dd@ideasonboard.com> <20260917-epaul-v7-3-rc1-x5h-vsp-fcp-v1-7-4c72d4e086dd@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260917-epaul-v7-3-rc1-x5h-vsp-fcp-v1-7-4c72d4e086dd@ideasonboard.com> On Thu, Sep 17, 2026 at 09:04:46PM +0900, Paul Elder wrote: > On some versions of the FCP, such as the one on the X5H, reset control > is required to operate the FCP. Add support for handling resets > optionally, to continue supporting versions that do not require it. > > Signed-off-by: Paul Elder > --- > drivers/media/platform/renesas/rcar-fcp.c | 34 +++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rcar-fcp.c b/drivers/media/platform/renesas/rcar-fcp.c > index d99b3ff976e80f275af19e5dc02c6e1de98c38a3..15bcbbda3b853f71780aae876f6440b33addf193 100644 > --- a/drivers/media/platform/renesas/rcar-fcp.c > +++ b/drivers/media/platform/renesas/rcar-fcp.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -63,6 +64,8 @@ > #define RCAR_FCP_REG_BA_REF_Y2 0x0118 > #define RCAR_FCP_REG_BA_REF_C 0x011c > > +struct reset_control; > + Not needed, you include linux/reset.h. > enum rcar_fcp_type { > RCAR_FCPF, > RCAR_FCPV, > @@ -73,6 +76,7 @@ struct rcar_fcp_device { > struct device *dev; > void __iomem *base; > enum rcar_fcp_type type; > + struct reset_control *rstc; > }; > > static LIST_HEAD(fcp_devices); > @@ -262,12 +266,19 @@ static int rcar_fcp_probe(struct platform_device *pdev) > fcp->dev = &pdev->dev; > fcp->type = (enum rcar_fcp_type)device_get_match_data(&pdev->dev); > > + platform_set_drvdata(pdev, fcp); > + > fcp->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(fcp->base)) > return PTR_ERR(fcp->base); > > dma_set_max_seg_size(fcp->dev, UINT_MAX); > > + fcp->rstc = devm_reset_control_get_optional(&pdev->dev, NULL); > + if (IS_ERR(fcp->rstc)) > + return dev_err_probe(&pdev->dev, PTR_ERR(fcp->rstc), > + "failed to get reset control\n"); > + > pm_runtime_enable(&pdev->dev); > ret = pm_runtime_resume_and_get(&pdev->dev); > if (ret < 0) > @@ -283,8 +294,6 @@ static int rcar_fcp_probe(struct platform_device *pdev) > list_add_tail(&fcp->list, &fcp_devices); > mutex_unlock(&fcp_lock); > > - platform_set_drvdata(pdev, fcp); > - > return 0; > > error_pm_put: > @@ -305,11 +314,32 @@ static void rcar_fcp_remove(struct platform_device *pdev) > pm_runtime_disable(&pdev->dev); > } > > +static int fcp_pm_runtime_suspend(struct device *dev) > +{ > + struct rcar_fcp_device *fcp = dev_get_drvdata(dev); > + > + reset_control_assert(fcp->rstc); No need for error checking ? > + return 0; > +} > + > +static int fcp_pm_runtime_resume(struct device *dev) > +{ > + struct rcar_fcp_device *fcp = dev_get_drvdata(dev); > + > + reset_control_deassert(fcp->rstc); Same here. Otherwise this looks good, but please move it before patch 06/10 as I would like to upstream this without 06/10. > + return 0; > +} > + > +static const struct dev_pm_ops fcp_pm_ops = { > + RUNTIME_PM_OPS(fcp_pm_runtime_suspend, fcp_pm_runtime_resume, NULL) > +}; > + > static struct platform_driver rcar_fcp_platform_driver = { > .probe = rcar_fcp_probe, > .remove = rcar_fcp_remove, > .driver = { > .name = "rcar-fcp", > + .pm = pm_ptr(&fcp_pm_ops), > .of_match_table = rcar_fcp_of_match, > .suppress_bind_attrs = true, > }, > -- Regards, Laurent Pinchart