mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Adarsh Das <adarshdas950@gmail.com>
Cc: rafael@kernel.org, dakr@kernel.org, driver-core@lists.linux.dev,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+4393dfdddf166f2de2b0@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] kobject: fix uevent socket use-after-free on net namespace delete
Date: Fri, 18 Sep 2026 09:14:59 +0100	[thread overview]
Message-ID: <2026091807-coma-unraveled-a65f@gregkh> (raw)
In-Reply-To: <20260918060826.8434-1-adarshdas950@gmail.com>

On Fri, Sep 18, 2026 at 11:38:26AM +0530, Adarsh Das wrote:
> @@ -804,14 +810,19 @@ static int uevent_net_init(struct net *net)
>  
>  static void uevent_net_exit(struct net *net)
>  {
> -	struct uevent_sock *ue_sk = net->uevent_sock;
> +	struct uevent_sock *ue_sk;
>  
> -	if (sock_net(ue_sk->sk)->user_ns == &init_user_ns) {
> -		mutex_lock(&uevent_sock_mutex);
> -		list_del(&ue_sk->list);
> -		mutex_unlock(&uevent_sock_mutex);
> +	{
> +		guard(mutex)(&uevent_sock_mutex);

LLMs don't know how to use these correctly, shouldn't this just be a
scoped_guard()?  No extra {} like that please, it's not normal kernel
coding style at all.

thanks,

greg k-h

  parent reply	other threads:[~2026-09-18  8:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 14:42 [PATCH] " Adarsh Das
2026-09-17 14:51 ` Greg KH
2026-09-17 15:18   ` Adarsh Das
2026-09-17 15:21     ` Greg KH
2026-09-17 17:08 ` [PATCH v2] " Adarsh Das
2026-09-17 17:08 ` Adarsh Das
2026-09-17 17:40   ` Greg KH
2026-09-18  6:08     ` [PATCH v3] " Adarsh Das
2026-09-18  8:14       ` Greg KH
2026-09-18  8:14       ` Greg KH [this message]
2026-09-18  9:43         ` [PATCH v4] " Adarsh Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026091807-coma-unraveled-a65f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=adarshdas950@gmail.com \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+4393dfdddf166f2de2b0@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®