Re: [PATCH net-next v8 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema

[Arthur Crepin Leblond <arthur@marmottus.net>]

On Thu, Sep 17, 2026 at 08:08:49PM +0000, netdev-bot+sashiko@kernel.org wrote:
>[Severity: Low]
>The description says the 14 MHz limit applies only to w5100 while 80 MHz
>applies to w5200/w5500, but the single maximum: 80000000 is applied to all
>three compatibles.  Should the w5100 limit be expressed as a conditional so
>dt_binding_check can enforce it?
>

The user should know which SPI speed to use here. I don't think
leaving the scheme open to higher speeds is a real issue.

>[Severity: Low]
>This changes the recommended trigger type from IRQ_TYPE_EDGE_FALLING in the
>removed .txt binding to IRQ_TYPE_LEVEL_LOW, and the deleted text also
>claimed "w5x00 natively generates falling edge interrupts".  Could the
>commit message mention this correction?
>
>The new value agrees with the driver, which requests the device interrupt
>level-low in w5100_probe():
>
>    err = request_threaded_irq(priv->irq, NULL, w5100_interrupt,
>                               IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>                               netdev_name(ndev), ndev);
>
>The commit message body only says the binding is converted from plain text
>to DT schema.  The only record of the trigger change is the v8 changelog
>line "Change edge-falling to level-low" below the --- separator, which git
>does not keep.
>

Nitpicky but I can add a line in the commit body.

Arthur