From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEBDD4AF9C7 for ; Fri, 18 Sep 2026 09:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722687; cv=none; b=A1RYRKjxK69N+nVG5OemyQFAPeY008pjyU3SVFX3ok4xAPXTZzjEMVWrwNuFRQoQ02HmjrimyvrPO8HSpC15YU56oiJtlpysGWf/QeyPGfPAXR9zOnmmAl7Y+xZrKJbQyxjKNXLe5ZsLowS1c0Rzst1KKmQtIB/gu7Ub9qSeySA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722687; c=relaxed/simple; bh=oxBm833C8T+jxHgAdbU6D4xcv4E4TYoli1xZPpTW0yQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ByN994CayLnOlfmJrPqZ0Ji8biID2EKeDzRww8FAPj9kb2pbPPWTKTuWWlwnmTQDCqU0QL/5qKlsOaj6TK1JkgR3cQ0gc0bbJ0GlFxCJsB2/jUmzGntZzW9JtItr7OBSPhbHpRKpE0pWfYxNxc1h6CjkhPu4RpAudj8VT0thdRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FIb6S5VI; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FIb6S5VI" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e7bcb94d3so3366895e9.2 for ; Fri, 18 Sep 2026 02:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789722684; x=1790327484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BcITG13Gvl8i0HA4g724jWVmnWns/ceZ5ECxTEaQlok=; b=FIb6S5VIl9HErXLXf5Fe7PjNK0bfdAWcityzeJbbPZkdgXU2pDq7mjpHJZyLUJjW8q SdyZvJddNcR4feZ8rlSEthkn69Qr5BFKlt5pT9FFuIimXOFkeopLSjz8jgeRFt3X2Uvr pdNb9HmpLKM1SGHE7kI7qbnQduD8fRQv0MpBaM5NBFAYo9pfoiUSIUkWW0Y86ciVptfW jV/OIr9u8w5Ocp8KoYH4Jum21j/3k9Vw1xCDDUIZHXSsjUeWUDwCarbOweFu57yGUsoZ d2e+hRuQ/QdfE1yE61YzY0RPRCSunnV+/K8BXUz7e/QdDIUU/zH8G3bpKp4z/KK8yXr+ ghgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789722684; x=1790327484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BcITG13Gvl8i0HA4g724jWVmnWns/ceZ5ECxTEaQlok=; b=mcIWSS4YhUUGndDN5DsyJU7w0/yy/WHQ2wZGfKSpiao7R9nqweyFYecj92WxuknKHu Q9CRv/NAcdBONQE6odEJIvKfFZiZy8uzrUV+62ACul7auW7hi17E55JYuPOAc6sSXFlo 5SqwoswWfFmYkZTL+EmMrKeUXYQ5TYgAo//2chPVF6f+bjnC9DyuIqtvKu/oHi0HC/xD SM5/JqnxPUJfkqWpTot1VHBLWWJwtWfS6K1VTloKrnPbBCoT7FijoSBSs6F9blK0hNsn vmCBz1tW4NYTO7vB2mUz3MIx5aUUs9suUNM+X7wbVEt2QV5tb+9qW52YSGJ+3iDN9WyS klqQ== X-Forwarded-Encrypted: i=1; AKwUvBzOAmeXtFzEUYlt5N8mrHrCITv3CD6yMHiFfKWa21QwYh9Lpvl4DZdn62QhXDKwDKOQTn9gZsZm1rd2kvg=@vger.kernel.org X-Gm-Message-State: AFuF++l7lmtHaTl/vztriswzotNchdBja8DA4NMoWL992po3vyi43/Hf ebKsPZwLdTL1f+pP7BSf0xktNg0ggSbENcK8g9vo4psLrVRqg1FUVPHb X-Gm-Gg: AYBFou1e240ac2qHLVHMHpVzd5Kf104mkTkpxmNaJq+fiwn2hlEH2iTR/KgOhnqPVcb vHrzyX5DWublRUmOEV9BQXcf5KWRsq2EqDOCfLt531otX8rXMDOzEltWQ4+KGVzD32Q9FjgCEiD jha+I0MkBy16CIaMFny2DvSkki/pS89sU0IIfLUvV4+jLj9uIpaydGWu+09kWO/2x8c8CYvW+7r fM7Rl06mqBkLIZ99qeUA/WN3ZIUin+Rql1V+4ho93UQQzGiBnO0qHg6x7rBCsf5ZVciCS+YBMcF m2XzKVKABt7iWvwRQLH6o7WqI50bS0hUFTLbo2FUl6W42ZqQcVMs/92KIIcbJEkyZDfbluc5omv kCbfExmrLy4CLK11LWCkrnyv0bg4kv55227AvBdFXq1hONnKzhY2jTrzwiG+2rZp8mK8J4bUnQs 6NOtgU64ZU1xLU3p3SdIOX0d36a/LewRWW3d/WQq3nU/OezPbkZsXfhcSsRBaDRtWM0gL17zCTG riZKOJLOolqGqk= X-Received: by 2002:a05:600c:468c:b0:49d:16df:8521 with SMTP id 5b1f17b1804b1-49fc56811dcmr23639585e9.4.1789722683646; Fri, 18 Sep 2026 02:11:23 -0700 (PDT) Received: from dell-desktop ([2a02:587:4b4e:8500:290c:210b:1c76:5710]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd1d0978sm138774275e9.2.2026.09.18.02.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 02:11:23 -0700 (PDT) From: Anastasios Papagiannis To: bpf@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org, akpm@linux-foundation.org, andrii@kernel.org, ast@kernel.org, brauner@kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, kpsingh@kernel.org, ljs@kernel.org, matt@bobrowski.net, memxor@gmail.com, song@kernel.org, sun.jian.kdev@gmail.com, utilityemal77@gmail.com, viro@zeniv.linux.org.uk, tasos.papagiannnis@gmail.com Subject: [PATCH bpf-next v8 2/5] exec: Clear bprm->mm before dropping its reference Date: Fri, 18 Sep 2026 12:10:55 +0300 Message-ID: <20260918091058.297740-3-tasos.papagiannnis@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260918091058.297740-1-tasos.papagiannnis@gmail.com> References: <20260918091058.297740-1-tasos.papagiannnis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Once mmput() drops the final reference to bprm->mm, the pointer must no longer remain accessible through struct linux_binprm. The successful exec path and the bprm initialization error path already clear bprm->mm when ownership is transferred or released. Do the same in free_bprm() before calling mmput(). This is required for BPF kfuncs where bprm->mm is either NULL or points to a live mm_struct to ensure safe access. Signed-off-by: Anastasios Papagiannis Reviewed-by: Sun Jian --- fs/exec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index 745f6eb5279e..4ddd403fd91c 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1456,9 +1456,12 @@ void bprm_drop_loader(struct linux_binprm *bprm) static void free_bprm(struct linux_binprm *bprm) { - if (bprm->mm) { + struct mm_struct *mm = bprm->mm; + + if (mm) { acct_arg_size(bprm, 0); - mmput(bprm->mm); + bprm->mm = NULL; + mmput(mm); } if (bprm->user_ns) put_user_ns(bprm->user_ns); -- 2.55.0