mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mizuno Miotsuki <founder@crepuse.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>
Subject: [RFC PATCH 0/1] ASoC: codecs: rk3308: add support for codec revision B
Date: Fri, 18 Sep 2026 12:57:18 +0000	[thread overview]
Message-ID: <20260918125711.94361-1-founder@crepuse.com> (raw)

Hi,

The current RK3308 internal codec driver detects codec revision B
(chip ID 0x3308) but explicitly rejects it. The initial 2022 driver
supported revision B with a monolithic power sequence; the later DAPM
rewrite left it unsupported.

This RFC restores the revision-specific DAC output VCM/current sequence
as a playback-only DAPM supply shared by HPOUT and LINEOUT. Per-channel
LINEOUT events override the shared DC baseline only while LINEOUT is
enabled. It does not restore the old codec-global power-on/off
functions, and capture-only streams do not touch DAC_ANA_CON14/15.

The original 2022 upstream v1 selected LINEOUT_FROM_INTERNAL for
revision B even for HPOUT-only playback. A newer Rockchip 6.1
downstream driver instead keeps CON15 at DC_FROM_INTERNAL for
HPOUT-only and selects LINEOUT_FROM_INTERNAL only for LINEOUT or
LINEOUT+HPOUT. This RFC follows the newer behaviour. Is that a hardware
sequencing fix that should be preserved?

On a DFRobot UNIHIKER M10 V1.2, revision-B probe, the board MICBIAS1
route, capture/playback PCM operation, capture isolation from CON14/15,
and the LINEOUT DAPM/register states were verified with the preceding
clean candidate. Physical onboard microphone capture was also
confirmed. A short transient at capture startup is also present with
the Rockchip vendor driver unless a longer wait is added, so it is not
treated as a regression and this RFC does not add a generic 250 ms mute
delay.

The shared-output revision is compile-tested but was not deployed.
Physical LINEOUT and HPOUT audio remain untested because suitable
hardware endpoints were unavailable. In particular, the HPOUT-only
CON15=0x22 choice still needs maintainer guidance or real-hardware
confirmation.

The M10 microphone route, its overly broad output topology, microphone PGA
controls, and capture-startup transient are deliberately kept outside this
codec RFC.

Regards,
Mizuno Miotsuki

Mizuno Miotsuki (1):
  ASoC: codecs: rk3308: add support for codec revision B

 sound/soc/codecs/rk3308_codec.c | 102 +++++++++++++++++++++++++++++++-
 1 file changed, 99 insertions(+), 3 deletions(-)

-- 
2.55.0

             reply	other threads:[~2026-09-18 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 12:57 Mizuno Miotsuki [this message]
2026-09-18 12:57 ` [RFC PATCH 1/1] " Mizuno Miotsuki
2026-09-18 12:58 ` [RFC PATCH 0/1] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918125711.94361-1-founder@crepuse.com \
    --to=founder@crepuse.com \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®