mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: bolin.liu@seu.edu.cn, sgoutham@marvell.com, rkannoth@marvell.com,
	gakula@marvell.com, sbhatta@marvell.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] octeontx2-af: skip absent MCS blocks in PTP configuration
Date: Fri, 18 Sep 2026 14:14:55 +0100	[thread overview]
Message-ID: <20260918131455.GJ51261@horms.kernel.org> (raw)
In-Reply-To: <178939359634.22033.5655691023198601345@kernel.org>

On Mon, Sep 14, 2026 at 01:46:36PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 (1) · Medium: 1 · Low: 0
> 
> - [Medium] The CNF10K-B branch of rvu_mcs_ptp_cfg() uses the CGX/RPM
>   index directly as the MCS block id: rvu_cgx_ptp_rx_cfg() obtains…
> 
> Pre-existing issues:
> - [High] mcs_get_pdata() walks the file-global mcs_list with no lock, no
>   RCU and no reference counting, while mcs_probe() inserts entries with…

Hi Slavin,

There is an expectation that AI-generated reviews forwarded to
the netdev ML are responded to. That can take a variety of forms
including an email response that agrees with or refutes the review,
or an updated version of the patch with an appropriate changelog.

The expectation is the patch author or submitter handles this.
But in order to move things along, in this case I've taken a look over it.
And it appears to me that both issues warrant addressing in
the context of this patch. Possibly expanding to a patch-set
containing more than a single patch in order to solve one problem per patch.

-- 
pw-bot: changes-requested

      reply	other threads:[~2026-09-18 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 12:52 Slavin Liu
2026-09-14  3:04 ` Ratheesh Kannoth
2026-09-14 13:46 ` netdev-bot+sashiko
2026-09-18 13:14   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918131455.GJ51261@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bolin.liu@seu.edu.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rkannoth@marvell.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®