From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
cassiogabrielcontato@gmail.com, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 11/15] ASoC: mediatek: mt8192: Remove redundant error message
Date: Fri, 18 Sep 2026 20:39:07 +0700 [thread overview]
Message-ID: <20260918133912.133799-12-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260918133912.133799-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
The errors handled here are already reported by the called functions,
either directly or deeper in the call chain. Therefore, the additional
dev_err() and dev_err_probe() call is redundant and can be removed.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
index 5aaff5bebfb6..45addf9f3790 100644
--- a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
+++ b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
@@ -2192,10 +2192,8 @@ static int mt8192_afe_pcm_dev_probe(struct platform_device *pdev)
/* init audio related clock */
ret = mt8192_init_clock(afe);
- if (ret) {
- dev_err(dev, "init clock error\n");
+ if (ret)
return ret;
- }
/* reset controller to reset audio regs before regmap cache */
rstc = devm_reset_control_get_exclusive(dev, "audiosys");
@@ -2271,7 +2269,7 @@ static int mt8192_afe_pcm_dev_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq_id, mt8192_afe_irq_handler,
IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
if (ret)
- return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle\n");
+ return ret;
/* init sub_dais */
INIT_LIST_HEAD(&afe->sub_dais);
--
2.43.0
next prev parent reply other threads:[~2026-09-18 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:38 [PATCH 00/15] ASoC: mediatek: mt8192: Improve error handling phucduc.bui
2026-09-18 13:38 ` [PATCH 01/15] ASoC: mediatek: mt8192: fix APLL mux " phucduc.bui
2026-09-18 13:38 ` [PATCH 02/15] ASoC: mediatek: mt8192: fix AFE clock " phucduc.bui
2026-09-18 13:38 ` [PATCH 03/15] ASoC: mediatek: mt8192: fix error handling in APLL enable functions phucduc.bui
2026-09-18 13:39 ` [PATCH 04/15] ASoC: mediatek: mt8192: fix MCK clock error handling phucduc.bui
2026-09-18 13:39 ` [PATCH 05/15] ASoC: mediatek: mt8192: switch to devm_clk_get_optional() phucduc.bui
2026-09-18 13:39 ` [PATCH 06/15] ASoC: mediatek: mt8192: Use dev_err_probe() in mt8192_init_clock() phucduc.bui
2026-09-18 13:39 ` [PATCH 07/15] ASoC: mediatek: mt8192: Propagate errors in mt8192_afe_gpio_request() phucduc.bui
2026-09-18 13:39 ` [PATCH 08/15] ASoC: mediatek: mt8192: Use dev_err_probe() for devm_pinctrl_get() phucduc.bui
2026-09-18 13:39 ` [PATCH 09/15] ASoC: mediatek: mt8192: check return values in mt8192_afe_gpio_init() phucduc.bui
2026-09-18 13:39 ` [PATCH 10/15] ASoC: mediatek: mt8192: Handle regcache_sync() failure in runtime resume phucduc.bui
2026-09-18 13:39 ` phucduc.bui [this message]
2026-09-18 13:39 ` [PATCH 12/15] ASoC: mediatek: mt8192: Propagate mt8192_afe_gpio_request() errors in ADDA DAI phucduc.bui
2026-09-18 13:39 ` [PATCH 13/15] ASoC: mediatek: mt8192: Propagate errors in TDM DAI DAPM event handlers phucduc.bui
2026-09-18 13:39 ` [PATCH 14/15] ASoC: mediatek: mt8192: Propagate errors in I2S " phucduc.bui
2026-09-18 13:39 ` [PATCH 15/15] ASoC: mediatek: mt8192-mt6359: Fix error handling in MTKAIF calibration phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918133912.133799-12-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=jiaxin.yu@mediatek.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®