From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44C14F96BD for ; Fri, 18 Sep 2026 14:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789740438; cv=none; b=KszB2FITdVf/WRJVDVVNNz1fLUHd43srdRbcWICK59Q8UTB1BzNwvZvPzmcarCjBLNs8iLWfg+yd0HVfKqFuDCox/oPBEGPCHmPJ1uIeLSd4BDkLJYMlJwCPBkCxj2GfcMqJe60bS0qJ+0DWgnGZRMSstDQ39Kgv4Rj1SsedWq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789740438; c=relaxed/simple; bh=9No6g42lrB6QKcCBOOEFSgMqI1po/ZrRv9DIdc2oFZ8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=qdj9lNP0ETEcvf181I8RzzGCYGDPqDLTz5Q9nuyWSIBPJAOsGWs662aiBQT5m4Y5cxITAroRRi+4MT5jlyu120Tf0tHnIQ9dtsFWK9KccM9rIlWyQVxXIdZgPyZHaLo4J4QfAO2EfvystWtu+m9B5yCIfAjvBittmvtDSxF6cJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AiEaB5FV; arc=none smtp.client-ip=209.85.216.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AiEaB5FV" Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e7ff7b375so1050765a91.1 for ; Fri, 18 Sep 2026 07:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789740436; x=1790345236; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dWUdAqwnRNViqY1JbSim/N3szd89pQRjSVQzSYadKOc=; b=AiEaB5FV5mNMjP0j3x8wl55S9XOOz8LnhIpBBRjtMc8OfNSuDKl3FMyEJq6eUO8FeN K8LaBvSmvTnG+i4ayzBsz6x38Z6zBQZaVbGOayTnR09SS2NtppsQCTknQK7bA+5RRvJa 0uMker55JkdBzxkIY4g7gTx54qTaWx9NRhJK7+GrV28CiUTQSEpygVw39KOqsJALyYLM jd20psB0UM/jFN8QXTEj47eqrYEvJai/YfgFLX6N25yLvYE0LmzOrrp8BSBACI0rKYAl 8uOHSknWyPzo0YKCWJK0cdVEujFW6Rg+a3ew/ChLyuMUvx/Ak5wSbbVYqv2inFsswtQY EweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789740436; x=1790345236; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dWUdAqwnRNViqY1JbSim/N3szd89pQRjSVQzSYadKOc=; b=IdC1dj4pnQk2wtOt6ZsTTIjXszJXv5MzAg4Q3wL9phh8XufOwO1qtgvUdD+PDkcwQ5 NTDGEQotZ3QdDojyfkBNwnBzQWs9EigpOpkt2Y/5ikEHAt7aRmHAxeHJ6OOXt8HaXz9z ToR2ubfnfasPD0TaYfV2jkV+qUJSJGFpNoqQKMdPGwtkeZ+ZYg0oj9Klc7Reno3idTwJ WgBSKJvu6O7a1NP5PFk800jL96r0eycqh841yAjT7hr2GsKCql7BFjhtBYSZV8eyXqgS 03wC5xc5ZG9u5pAI+qxbd/D8zqvpOo4JpR9EclcENRz4yH5Lgwu169KPxuJlXNbWAsNl 9UMQ== X-Forwarded-Encrypted: i=1; AKwUvBwVDDfQ9RhzQufE+agPZYWmowRAXUzD4kwOXQPHkxFK3e1dmgziA6SIYDv210BUvBOCLpGL+FndNtBMRrk=@vger.kernel.org X-Gm-Message-State: AFuF++miRP2CLRYDrmTLoztqxpEpoXbvxCGR4c94HGeKBfF255b+fHTW U6uzgtVCu2yqTqZUEaDEDTqD2vNQEFZ1PYOjbrwW9s6cuM0Dzpz0kYzsf9tS8hiPF+aj7t0SEJO Y+yoGlXrYqA== X-Received: from dybfx26.prod.google.com ([2002:a05:7300:c39a:b0:33c:2bb7:a004]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2784:b0:39e:6a80:dda4 with SMTP id 98e67ed59e1d1-39e6a810c81mr72789a91.43.1789740435877; Fri, 18 Sep 2026 07:07:15 -0700 (PDT) Date: Fri, 18 Sep 2026 07:06:46 -0700 In-Reply-To: <20260918140659.2501976-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260918140659.2501976-1-irogers@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260918140659.2501976-4-irogers@google.com> Subject: [PATCH v3 03/16] perf trace: Start BPF summary before starting workload From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org Cc: adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" When using --bpf-summary, trace_start_bpf_summary() sets skel->bss->enabled = 1. In trace__run(), trace_start_bpf_summary() was previously invoked after evlist__start_workload(). Because evlist__start_workload() immediately unblocks the child process by writing to its go_pipe, short-lived workloads (such as `cat /dev/null`) can execute and complete their initial system calls before trace_start_bpf_summary() is reached by the parent process. Furthermore, under high system load, the child process may finish before the BPF summary tracking is enabled in the kernel at all, causing syscall summary tests to fail. Additionally, if initial_delay was configured, the workload was started before sleeping. Move trace_start_bpf_summary() to be invoked before evlist__start_workload(), matching evlist__enable(), and ensure it respects target.initial_delay. Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- tools/perf/builtin-trace.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f67557e7a254..f90c6bb4d8b4 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -4844,17 +4844,19 @@ static int trace__run(struct trace *trace, int argc, const char **argv) if (!target__none(&trace->opts.target) && !trace->opts.target.initial_delay) evlist__enable(evlist); + if (trace->summary_bpf && !trace->opts.target.initial_delay) + trace_start_bpf_summary(); + if (forks) evlist__start_workload(evlist); if (trace->opts.target.initial_delay) { usleep(trace->opts.target.initial_delay * 1000); evlist__enable(evlist); + if (trace->summary_bpf) + trace_start_bpf_summary(); } - if (trace->summary_bpf) - trace_start_bpf_summary(); - trace->multiple_threads = perf_thread_map__pid(evlist__core(evlist)->threads, 0) == -1 || perf_thread_map__nr(evlist__core(evlist)->threads) > 1 || evlist__first(evlist)->core.attr.inherit; -- 2.55.0.1082.g2b9226bbc0-goog