From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
linux-watchdog@vger.kernel.org
Subject: [PATCH] watchdog: use assign_bit() where applicable
Date: Fri, 18 Sep 2026 22:19:14 +0800 [thread overview]
Message-ID: <20260918141915.3023207-1-peng.fan@oss.nxp.com> (raw)
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit and their
non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit
API.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/watchdog/watchdog_core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
index 38c1e63a8e2c..2948fe52e093 100644
--- a/drivers/watchdog/watchdog_core.c
+++ b/drivers/watchdog/watchdog_core.c
@@ -314,10 +314,7 @@ static int ___watchdog_register_device(struct watchdog_device *wdd)
/* Module parameter to force watchdog policy on reboot. */
if (stop_on_reboot != -1) {
- if (stop_on_reboot)
- set_bit(WDOG_STOP_ON_REBOOT, &wdd->status);
- else
- clear_bit(WDOG_STOP_ON_REBOOT, &wdd->status);
+ assign_bit(WDOG_STOP_ON_REBOOT, &wdd->status, stop_on_reboot);
}
if (test_bit(WDOG_STOP_ON_REBOOT, &wdd->status)) {
--
2.51.0
next reply other threads:[~2026-09-18 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:19 Peng Fan (OSS) [this message]
2026-09-18 15:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918141915.3023207-1-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peng.fan@nxp.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®