From: Christoph Hellwig <hch@lst.de>
To: yupeng <yupeng0921@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] nvmet: add cgroup_path to charge namespace I/O to a cgroup
Date: Fri, 18 Sep 2026 16:24:27 +0200 [thread overview]
Message-ID: <20260918142427.GA19316@lst.de> (raw)
In-Reply-To: <20260908011214.11344-1-yupeng0921@gmail.com>
cgroup charing does seem useful. But please do a human pass on the
code and especially the commit log and text in documentation, this
Claude slop is unreadable, and I also really want to you to be able
to explain the details of the new code. Please also Cc the cgroup
mailing list for the next version, as they are much better than us
nvme maintainers to judge if you're using the cgroup APIs correctly.
prev parent reply other threads:[~2026-09-18 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 1:12 yupeng
2026-09-18 14:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918142427.GA19316@lst.de \
--to=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yupeng0921@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®