mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	pavel@nabladev.com, jonathanh@nvidia.com, f.fainelli@gmail.com,
	sudipm.mukherjee@gmail.com, rwarsow@gmx.de, conor@kernel.org,
	hargar@microsoft.com, broonie@kernel.org, achill@achill.org,
	sr@sladewatkins.com
Subject: Re: [PATCH 6.12 0000/1102] 6.12.111-rc1 review
Date: Fri, 18 Sep 2026 11:54:05 -0400	[thread overview]
Message-ID: <20260918151138.2101477303-sashal@kernel.org> (raw)
In-Reply-To: <aqxLGIyiWCdsQoyR@duo.ucw.cz>

On Thu, Sep 17, 2026 at 10:18:32PM +0200, Pavel Machek wrote:
> drivers/net/ethernet/ti/cpsw.c: In function 'cpsw_ndo_set_rx_mode_work':
> ./include/linux/container_of.h:20:54: error: 'struct cpsw_priv' has no
> member named 'rx_mode_work'

Dropped from the 6.12 and 6.6 queues:

  0b8c878d1173 ("net: cpsw: Execute ndo_set_rx_mode callback in a work
                 queue")

It only touches drivers/net/ethernet/ti/cpsw.c, but the
'struct work_struct rx_mode_work' member it uses is added to cpsw_priv.h
by a different commit, c0b5dc73a38f ("net: cpsw_new: Execute
ndo_set_rx_mode callback in a work queue"), which isn't queued anywhere.
6.6 additionally lacks disable_work_sync(), so it could not have built
there either.

> I don't have good diagnostic for runtime problem on arm. Example is here:
> (hang)

> It is better on x86:
> L328[    0.264887] RIP: 0010:gather_bootmem_prealloc_parallel+0x117/0x250
[...]
> L343[    0.264887]  hugetlb_bootmem_struct_page_init+0x6f/0x90

That one is a second, independent problem, also dropped from the 6.12
queue:

  b1b7c045e808 ("mm/hugetlb: initialize gigantic bootmem hugepage
                 struct pages earlier")

The backport moves gather_bootmem_prealloc() into page_alloc_init_late(), which
on 6.12 runs before anything initializes the per-node huge_boot_pages[] list
heads - upstream that happens unconditionally in hugetlb_bootmem_alloc() since
v6.15, which 6.12 does not have. Without hugepagesz=/hugepages= on the command
line the list head is still all zeroes, so the first list_for_each_entry()
iteration yields NULL and m->hstate faults - which matches your log exactly
(CR2 0000000000000010, 'mov r15,[r12+0x10]' with r12 == 0, .hstate sitting at
offset 0x10 in struct huge_bootmem_page).

Two independent bisects from Brett Sheffield and Peter Schneider landed on the
same commit.

-- 
Thanks,
Sasha

  parent reply	other threads:[~2026-09-18 15:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 14:59 Greg Kroah-Hartman
2026-09-17 16:57 ` Florian Fainelli
2026-09-17 19:11 ` Peter Schneider
2026-09-17 20:21   ` Pavel Machek
2026-09-18 15:54     ` Sasha Levin
2026-09-17 19:35 ` Brett A C Sheffield
2026-09-17 20:19   ` Peter Schneider
2026-09-18  5:49     ` Peter Schneider
2026-09-18 15:54       ` Sasha Levin
2026-09-18 15:54     ` Sasha Levin
2026-09-18 15:54   ` Sasha Levin
2026-09-17 20:18 ` Pavel Machek
2026-09-18 11:27   ` Jon Hunter
2026-09-18 15:54     ` Sasha Levin
2026-09-18 15:54   ` Sasha Levin [this message]
2026-09-18  7:16 ` [PATCH 6.18 0000/1250] 6.18.53-rc1 review Wentao Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918151138.2101477303-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=achill@achill.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=conor@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hargar@microsoft.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=patches@kernelci.org \
    --cc=patches@lists.linux.dev \
    --cc=pavel@nabladev.com \
    --cc=rwarsow@gmx.de \
    --cc=shuah@kernel.org \
    --cc=sr@sladewatkins.com \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®