From: Rob Herring <robh@kernel.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: Eliav Farber <farbere@amazon.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: pps: pps-gpio: document optional pinctrl states
Date: Fri, 18 Sep 2026 10:43:53 -0500 [thread overview]
Message-ID: <20260918154353.GA4133751-robh@kernel.org> (raw)
In-Reply-To: <78b01d9f-5551-4bb8-8fe1-9a992f624810@enneenne.com>
On Fri, Sep 18, 2026 at 09:50:06AM +0200, Rodolfo Giometti wrote:
> On Thu, Sep 17, 2026 at 07:56:10AM +0000, Eliav Farber wrote:
> > Document the optional "default" and "inactive" pinctrl-names and show
> > both in the example.
> >
> > Signed-off-by: Eliav Farber <farbere@amazon.com>
> > ---
> > diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > index 383a838744eb..db6ecb17cb54 100644
> > --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > @@ -28,6 +28,19 @@ properties:
> > description: Indicates a falling edge assert, when present. Rising edge if absent.
> > type: boolean
> >
> > + pinctrl-names:
> > + description:
> > + When the PPS input is muxed through a pin controller, the standard
> > + "default" state selects the PPS/GPIO function and is applied by the
> > + driver core before probe. If a state named "inactive" is also present,
> > + it is selected when the driver is unbound or the system is shut down,
> > + handing the pins back to their alternate function. The "inactive"
> > + state, if used, requires a "default" state; its position among the
> > + names does not matter.
> > + minItems: 1
> > + contains:
> > + const: default
> > +
> > required:
> > - compatible
> > - gpios
> > @@ -40,8 +53,9 @@ examples:
> >
> > pps {
> > compatible = "pps-gpio";
> > - pinctrl-names = "default";
> > + pinctrl-names = "default", "inactive";
> > pinctrl-0 = <&pinctrl_pps>;
> > + pinctrl-1 = <&pinctrl_pps_inactive>;
> > gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> > assert-falling-edge;
> > echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
>
> I tried:
>
> $ make DT_SCHEMA_FILES=Documentation/devicetree/bindings/pps/pps-gpio.yaml \
> dt_binding_check
>
> and it gave me:
>
> pps-gpio.example.dtb: pps (pps-gpio): pinctrl-names:
> ['default', 'inactive'] is too long
> from schema $id: http://devicetree.org/schemas/pps/pps-gpio.yaml
I can't help you without the schema you used. Sounds like something
wrong with 'items'.
Rob
next prev parent reply other threads:[~2026-09-18 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 13:47 [PATCH 0/2] pps-gpio: restore pin mux on unbind and shutdown Eliav Farber
2026-09-16 13:47 ` [PATCH 1/2] dt-bindings: pps: pps-gpio: document optional idle pinctrl state Eliav Farber
2026-09-16 13:47 ` [PATCH 2/2] pps: clients: gpio: release pins to idle state on remove and shutdown Eliav Farber
2026-09-16 16:48 ` [PATCH 0/2] pps-gpio: restore pin mux on unbind " Rodolfo Giometti
2026-09-16 18:25 ` Farber, Eliav
2026-09-16 18:26 ` [PATCH v2 " Eliav Farber
2026-09-16 18:26 ` [PATCH v2 1/2] dt-bindings: pps: pps-gpio: document optional pinctrl states Eliav Farber
2026-09-17 7:13 ` Rodolfo Giometti
2026-09-17 7:48 ` Farber, Eliav
2026-09-16 18:26 ` [PATCH v2 2/2] pps: clients: gpio: release pins to an inactive state on remove and shutdown Eliav Farber
2026-09-17 7:14 ` Rodolfo Giometti
2026-09-17 7:52 ` Farber, Eliav
2026-09-17 7:56 ` [PATCH v3 0/3] pps-gpio: restore pin mux on unbind " Eliav Farber
2026-09-17 7:56 ` [PATCH v3 1/3] pps: clients: gpio: propagate probe error codes Eliav Farber
2026-09-17 9:58 ` Bartosz Golaszewski
2026-09-18 7:50 ` Rodolfo Giometti
2026-09-17 7:56 ` [PATCH v3 2/3] dt-bindings: pps: pps-gpio: document optional pinctrl states Eliav Farber
2026-09-17 15:35 ` Rob Herring (Arm)
2026-09-17 16:13 ` Rob Herring
2026-09-18 7:50 ` Rodolfo Giometti
2026-09-18 15:43 ` Rob Herring [this message]
2026-09-17 7:56 ` [PATCH v3 3/3] pps: clients: gpio: release pins to an inactive state on remove and shutdown Eliav Farber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918154353.GA4133751-robh@kernel.org \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farbere@amazon.com \
--cc=festevam@gmail.com \
--cc=giometti@enneenne.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®