From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f12.google.com (mail-ed2-f12.google.com [74.125.228.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC2E3D79FB for ; Fri, 18 Sep 2026 15:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789744667; cv=none; b=rTXOwXy4tqinaLPaIeiVab23dvExcsCSq5W2lSZO5dx5FchqPly9n82u8O6DAlyBIYvSBoCTKABB0zNOPk/g1afu5lf+qwkHIkDpLQok1oyCFU9pSmAvk3V+8KJsPQk/WATciUKgp4TsvuBXptX8Yq9pPT02XVxjwXmsnVonAsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789744667; c=relaxed/simple; bh=lCzf76+NJFiZBWowe56JipIaRmY6y097OMCOguKq84Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uBPhaTTDF0r4uybiTEFEOwHO6OLf6bVwIzsQQb08x06WdQqnRwXgno7QmM26MEL1zF637T0kVdgb5egKhOc8S4wnsnRzjmtfVtEON2eQY6DrX7ST+BWwUpkJgpeDUOuWJIJDjBGc53vS5PJvqkrIBBA9ylCgNJNla8jLO0OwoGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MAau96Qc; arc=none smtp.client-ip=74.125.228.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MAau96Qc" Received: by mail-ed2-f12.google.com with SMTP id 4fb4d7f45d1cf-6a605844571so1110253a12.3 for ; Fri, 18 Sep 2026 08:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789744663; x=1790349463; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7cqdA0O8Ahj4mmcXHJ140W7PNv8oloRpbbh1DU0ab2Y=; b=MAau96Qcy437Rhkb8qb17CTu/aCU/UUHNgKUJPbxMde8RMu3sRQHlxHTf/cb99qzY/ O5jyEgt72sKg5WOvC1qFIwrRrZ3/wmt3HXEZ09Oht9so+sUPKzIICQ9XaogQOZbqdBL7 zEDreqNkdyjdcz38U2FuWBJk8V5R8InTTzk8DPBi/O8z6jd44XWhbxbp/6SgZq8Oq5vq l6HrAkyumm+GZM1a54A2T/uscFhJzQZLmnG0LBKJbWKKhl6qxLorBEkg3vTZyxwaIHkd +neg5o1voE/b4rmCie9MACURh8yiBzvFRLtWRFKp33u8QoCYYvDJ1EZHBxXj6YIWzcE5 /1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789744663; x=1790349463; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7cqdA0O8Ahj4mmcXHJ140W7PNv8oloRpbbh1DU0ab2Y=; b=Hkjmf6alwA7nBB68iO6/yfBIN49+s0WOZOn43sRW1VFTPQesfKzfgijsrjhI27iRPc 60VRGmTdguDvTNECaZimihn2B+Cimah8ADYS43PG5DJx1oiuMFE1sPUfMGf8CVekh/PC J0GyipPa5xNS9ibMwraZkOOuCVPfuonDuXVVcidHeaUU6OPBJtLhRkXTzRCqEaLG8B7x IpKWreodkU8TZ/Rr6PcltO7LsxmuBio9gv2O9NFt3Ir5rInF2AaRcs82Iq+R7N7NKt4C V0WmE5dgOKbC/aJm9xEkakjM104ReB+jCKKlmA0AYWVt/0/cgrwj0xr7/TfaMet9mSV3 0dkg== X-Forwarded-Encrypted: i=1; AKwUvBzNdCN3xlKi7JM2LYCVlPNQ+w/w/GBBe0OrhXbu2N5soH+HInqJdLiXqNrhRZUZ3w9v0Ra8nl/8CtaJmtA=@vger.kernel.org X-Gm-Message-State: AFuF++k5gmbO2NB9aa6IguKSBvbUyb6TD9eqv9T7xG6qvNrNrOiKMOg+ aepTfgchp1jvGjJMIEB1ZbEpsXKAW4MnHAsB+u+cdvj+FEUKa6QHA9eg X-Gm-Gg: AYBFou10d6ftsvz1M4ttpqdCSAUZNpCdDTI58mUTSvC+pNjbteVEO4EzqhCJ9W9x298 U9Dc1Sq1w2j9bMcyxTdrun0Lf9NhGfIn+OCZz37+OMCoyVc8cbDlgi8GrYQtXt7G4q6FRo08RxA s7MabokdLXUSnRRxpdirCHaZQ6lI98RuEHbO7lckgVa4IN17Ve2awrvIqYJA5d0kDGW1rjai8O8 JNlfiu3Hae81ulsfAU/7zD58Otjt0U0KnquMB1NnWOnZEFqk8Ej4jEONC8oY5wiTD9i7EcmFVwD E4pD1ZCBZHwh7l9tN6uUYQMNjYbcbnciqtWWvVHrPYEZErG2N+CCJU+M1HAsA7dmjT0Cgpt7okL Lghde0QrsystD5yI2z0L266ESIsSw/dya0FoAi9vUut/eyYDqZ5fIjQDal0ptzxhoIzU4g35ctS 69X6kWj89Ts3p24X3E42GNitc+LGhplguVihpkGNF6ajgPBlCn/SiW6723yDqahx9/5pg/sTpj1 9qgiR/L8CfW5G6W8Rq/J6cjuxapM4bw4F5K X-Received: by 2002:a17:907:960d:b0:c29:d3ad:4f72 with SMTP id a640c23a62f3a-c2a157da677mr272170666b.16.1789744663392; Fri, 18 Sep 2026 08:17:43 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a1bb42643sm74893366b.26.2026.09.18.08.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 08:17:42 -0700 (PDT) Date: Fri, 18 Sep 2026 16:17:41 +0100 From: David Laight To: Florian Weimer Cc: Andy Lutomirski , Mikko Rantalainen , Rich Felker , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, alx@kernel.org Subject: Re: [RFC PATCH 0/1] close(): stop exposing non-retryable EINTR Message-ID: <20260918161741.1d95bd4f@pumpkin> In-Reply-To: References: <20260913193815.2862366-1-mikko.rantalainen@peda.net> <20260913235145.GY25906@brightrain.aerifal.cx> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 18 Sep 2026 14:56:39 +0200 Florian Weimer wrote: > * Andy Lutomirski: > > > I think I mostly agree with your analysis except that I really don't > > like the ENOSPC. The kernel actually has the ability to commit to > > having space for pending writes on an fd *without syncing*, then I > > think that capability should be expose to userspace. fsync is a > > pretty poor alternative for code that just wants to make sure that, in > > the absence of a bug, crash or physical failure, the data won't be > > lost. > > It's something we might want to call from fflush. > > As a replacement, dup3/close doesn't quite work because it releases > POSIX advisory locks on the original descriptor (as they are per > process, not per descriptor). POSIX advisory locks are completely broken by design. They just don't work for threaded processes at all. Thread 1 thread 2 thread 3 open lock open close open lock - succeeds The same could easily happen if a single threaded process opens the same file multiple times. David > > Thanks, > Florian > >