From: Jakub Kicinski <kuba@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Kevin Curtis <kevin.curtis@farsite.co.uk>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: wan: farsync: disable PCI device on removal
Date: Fri, 18 Sep 2026 16:55:55 -0700 [thread overview]
Message-ID: <20260918165555.2ed3bf2d@kernel.org> (raw)
In-Reply-To: <20260916063118.2924049-1-lgs201920130244@gmail.com>
On Wed, 16 Sep 2026 14:31:18 +0800 Guangshuo Li wrote:
> fst_add_one() calls pci_enable_device() to enable the PCI device. The
> probe failure paths call pci_disable_device() to release the matching
> enable reference, but fst_remove_one() does not disable the device
> after a successful probe.
>
> As a result, the PCI device enable reference remains unbalanced after
> the driver is removed.
>
> Call pci_disable_device() after the existing interrupt, tasklet,
> mapping, DMA and PCI region cleanup to release the enable reference.
>
> This issue was found by manual code inspection.
Ancient stuff, no point.
prev parent reply other threads:[~2026-09-18 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 6:31 Guangshuo Li
2026-09-18 23:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918165555.2ed3bf2d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kevin.curtis@farsite.co.uk \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®