From: Guangshuo Li <lgs201920130244@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Guangshuo Li <lgs201920130244@gmail.com>, stable@vger.kernel.org
Subject: [PATCH] scsi: sni_53c710: put SCSI host on remove
Date: Sat, 19 Sep 2026 01:52:18 +0800 [thread overview]
Message-ID: <20260918175218.3616645-1-lgs201920130244@gmail.com> (raw)
snirm710_probe() obtains a SCSI host through NCR_700_detect(). The
probe failure path drops the host reference with scsi_host_put(), but
the normal remove path does not perform the corresponding cleanup.
As a result, the SCSI host reference remains allocated after the
device is removed.
Call scsi_host_put() after all users of the SCSI host have been torn
down to release the reference acquired during probe.
This issue was found by manual code inspection.
Fixes: c27d85f3f3c5 ("[SCSI] SNI RM 53c710 driver")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/scsi/sni_53c710.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/sni_53c710.c b/drivers/scsi/sni_53c710.c
index b504a2cc5041..7c5b1929a6a7 100644
--- a/drivers/scsi/sni_53c710.c
+++ b/drivers/scsi/sni_53c710.c
@@ -115,6 +115,7 @@ static void snirm710_driver_remove(struct platform_device *dev)
free_irq(host->irq, host);
iounmap(hostdata->base);
kfree(hostdata);
+ scsi_host_put(host);
}
static struct platform_driver snirm710_driver = {
--
2.43.0
reply other threads:[~2026-09-18 17:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918175218.3616645-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®