From: Guangshuo Li <lgs201920130244@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Guangshuo Li <lgs201920130244@gmail.com>, stable@vger.kernel.org
Subject: [PATCH] scsi: zorro7xx: put SCSI host on remove
Date: Sat, 19 Sep 2026 02:02:01 +0800 [thread overview]
Message-ID: <20260918180201.3624568-1-lgs201920130244@gmail.com> (raw)
zorro7xx_init_one() obtains a SCSI host through NCR_700_detect(). The
probe failure path drops the host reference with scsi_host_put(), but
the normal remove path does not perform the corresponding cleanup.
As a result, the SCSI host reference remains allocated after the
device is removed.
Call scsi_host_put() after all users of the SCSI host have been torn
down to release the reference acquired during probe.
This issue was found by manual code inspection.
Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/scsi/zorro7xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c
index 21c769dc1ecb..a8b0c2d4a9cb 100644
--- a/drivers/scsi/zorro7xx.c
+++ b/drivers/scsi/zorro7xx.c
@@ -164,6 +164,7 @@ static void zorro7xx_remove_one(struct zorro_dev *z)
kfree(hostdata);
free_irq(host->irq, host);
zorro_release_device(z);
+ scsi_host_put(host);
}
static struct zorro_driver zorro7xx_driver = {
--
2.43.0
next reply other threads:[~2026-09-18 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 18:02 Guangshuo Li [this message]
2026-09-21 15:17 ` krzk
2026-09-22 2:57 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918180201.3624568-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=James.Bottomley@SteelEye.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®