From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D62C9528435 for ; Fri, 18 Sep 2026 21:19:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789766388; cv=none; b=l90tpqQT94TyhmQr+ge3K1TL2BWrwr4D9TRBFaQ2i7L4/NDL6Ij9c78+zyPauFh5q34h2/dAD/ryWUk7g1bGtUCreDnpf5SYhe4IAjaxGEMJ62vdekrNbdUPFxXGvBpeBOLiIoeWEGBdhwHPLxWXyL7U14Hy7j6TS3DFtcA9iKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789766388; c=relaxed/simple; bh=Bl7p5fPq1zzv8earO2MgxKfTQKk3Ks5v1cj5G/bckVs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VvYZqPSOUuHrDJBbcogskObmmJOdUfxKunm1h8I2nY3ns8J+Yvz5e0gUTSeffRmqjyc6pzxQQZsHK9OKvBnA2uhleiu0UP2rbpxndAqRmKj/iPPjOFh3QFTXLatZa/IU+aOJSwrk9QNrlavnYo5cA4d2KgM3y1lHxsA+qNe39MY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=p4bBk+GQ; arc=none smtp.client-ip=209.85.216.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p4bBk+GQ" Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-39de1f85cb2so1518175a91.0 for ; Fri, 18 Sep 2026 14:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789766386; x=1790371186; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q198WRfVuFdwy23wGpDOJAEDHlwObTAenaQ9DfUue+I=; b=p4bBk+GQXz8+40B3xQ7ywYnp376nYIN/jJYpMclPYueuHMJk1Uf3AkzPj1OgjU8MX0 qRgLwViCC7y9pRmx/5r/L5KBiddEClU67X7wp5+cKkA6xyw8VM/k99rsSApuHZexqq3V 3g6a0/CMkfMIjgobWjFTcTgSdTS8exAFjiHI8CetLhW8bis3zBnLv8xkPHtAKMdTZvqj uS8LGrPTJj8W4PL/9WsRFzM/LFD30WCZSeDUASDsBjLMRDfyglxwHVfIDNCGx0vm/gJO vxIgPJLM/MStvneQTHFb4sMLrnxg31NYRGAsUGMs7hMn8yYhBblzPcqnAffRZ7OLvC7O 3jkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789766386; x=1790371186; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q198WRfVuFdwy23wGpDOJAEDHlwObTAenaQ9DfUue+I=; b=dEUiMq7K5OEyxHHacsRbrE3uB6QSjQxto1f/5EeVgspgzuK1CDOhYFkawboZYhKnKU X8M3v4LN+nvI2HBv9frn3ipSn6hWrhV11fbjnrbxBXlLs7srKHFoS0prCq7cQaljZ5lH 6BlAxpch7CTzEuOFKl+847QbdfGZTw9gCP2lRKiHXG3+1d4U/3GlHlV3fnJhIGYTYqYz 9tO1yOJhwaZzSNQ9h89VAk2HjweD5ec9yhppwFfaY89cNUU/OjL1UQpDTD1WkMMeYaiC rRl5CRRmol0GIHY6gp4cx7s/+RCQ6dGS7eIFqBAdrT9Y3P3qj9VaWR3iUJCp14VLoDTt qSIg== X-Forwarded-Encrypted: i=1; AKwUvBxH1VQ6b7TTjbCZivGatxRelvP7FgXGtb7E2Xjim1jb0Haow6+ebr8QFx/BQnAt8/kM4nJBhOvzVspH8EE=@vger.kernel.org X-Gm-Message-State: AFuF++lZf8z7glkBCwSoi8lgdFoXyjyXwQYoQP3rum2vhJwseS/PYh0T Xc2fxfxzjaXjGruij7MCuThgQfiabIvqkPAZy7rx75poiviIbdZN6eGqY4g7vUnK76gE/zHQBOZ 18+rFFSUhhg== X-Received: from dlbqq10.prod.google.com ([2002:a05:7022:ed0a:b0:143:7c9b:184f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2ecb:b0:39e:31ec:ba55 with SMTP id 98e67ed59e1d1-39e54d36b09mr8589531a91.7.1789766386140; Fri, 18 Sep 2026 14:19:46 -0700 (PDT) Date: Fri, 18 Sep 2026 14:19:15 -0700 In-Reply-To: <20260918211932.2966061-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260918140659.2501976-1-irogers@google.com> <20260918211932.2966061-1-irogers@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260918211932.2966061-2-irogers@google.com> Subject: [PATCH v4 01/18] perf trace: Include the headers declaring pid_t, strcmp and assert From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org, Howard Chu Cc: adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" trace_augment.h uses pid_t in the augmented_syscalls__set_filter_pids() prototype and in the !HAVE_BPF_SKEL stub. bpf_trace_augment.c calls strcmp() in augmented_syscalls__find_by_title() and assert() in augmented_syscalls__create_bpf_output(), but neither pulls in the header that declares what it uses. Both happen to build today only because something else in the include chain drags , and in first, which is not guaranteed and does not hold on libcs such as musl that keep the POSIX namespaces strictly separated. Include , and explicitly. Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- tools/perf/util/bpf_trace_augment.c | 2 ++ tools/perf/util/trace_augment.h | 1 + 2 files changed, 3 insertions(+) diff --git a/tools/perf/util/bpf_trace_augment.c b/tools/perf/util/bpf_trace_augment.c index a9cf2a77ded1..ebb26225fb04 100644 --- a/tools/perf/util/bpf_trace_augment.c +++ b/tools/perf/util/bpf_trace_augment.c @@ -1,5 +1,7 @@ +#include #include #include +#include #include "bpf_skel/augmented_raw_syscalls.skel.h" #include "debug.h" diff --git a/tools/perf/util/trace_augment.h b/tools/perf/util/trace_augment.h index 4f729bc67753..a1cd9a5e0213 100644 --- a/tools/perf/util/trace_augment.h +++ b/tools/perf/util/trace_augment.h @@ -2,6 +2,7 @@ #define TRACE_AUGMENT_H #include +#include struct bpf_program; struct evlist; -- 2.55.0.1082.g2b9226bbc0-goog