From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org, Zecheng Li <zli94@ncsu.edu>,
Yanbo Zhao <yzhao62@ncsu.edu>,
Tengda Wu <wutengda@huaweicloud.com>,
Shuai Xue <xueshuai@linux.alibaba.com>
Subject: [PATCH v5 0/4] perf annotate-data: Support flexible array types
Date: Fri, 18 Sep 2026 23:37:41 -0700 [thread overview]
Message-ID: <20260919063745.48444-1-namhyung@kernel.org> (raw)
Hello,
The flexible arrays are dynamically allocated with different size. So checking
with the original type size won't match and cannot find the type if the offset
is bigger than the size. This patch series detects those flex-arrays and allows
accesses beyong the original size.
I'm not sure what's the best way to add test codes for data type profiling as it
seems we need to add a lot more workloads for different cases. Probably we may
want to split the workloads as separate binaries.
v5 changes)
* add a cleanup patch
* add is_union and is_flex_array fields to find member correctly
v4: https://lore.kernel.org/r/20260916061926.2224222-1-namhyung@kernel.org/
* update last member even if the offset is same
* handle type qualifiers in die_has_flex_array()
* add zero-length array members as flexible arrays
* check return value of strbuf_init() for type name
v3: https://lore.kernel.org/r/20260915064035.1970175-1-namhyung@kernel.org
* patch 1 was merged!
* check if last member is found
* check member location when finding flex-array
* ensure member typename is initiailized
* fix a bug to pass a wrong type in check_variable()
* fix a typo in a comment
v2: https://lore.kernel.org/r/20260914064535.1671939-1-namhyung@kernel.org
* fix missing index increment in the histogram
* support flex array in union types
* add recursion check in die_has_flex_array()
* check negative index arrays properly
* avoid divide-by-zero when the size is unknown
v1: https://lore.kernel.org/r/20260912054706.1475583-1-namhyung@kernel.org
Thanks,
Namhyung
Cc: Zecheng Li <zli94@ncsu.edu>
Cc: Yanbo Zhao <yzhao62@ncsu.edu>
Cc: Tengda Wu <wutengda@huaweicloud.com>
Cc: Shuai Xue <xueshuai@linux.alibaba.com>
Namhyung Kim (4):
perf dwarf-aux: Add die_has_flex_array() helper
perf annotate-data: A small cleanup in __add_member_cb()
perf annotate-data: Allow out-of-size access for flex-array types
perf annotate-data: Adjust type offset for flex-array
tools/perf/util/annotate-data.c | 192 ++++++++++++++++++++++++--------
tools/perf/util/annotate-data.h | 6 +
tools/perf/util/dwarf-aux.c | 107 ++++++++++++++++++
tools/perf/util/dwarf-aux.h | 3 +
4 files changed, 262 insertions(+), 46 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-19 6:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 6:37 Namhyung Kim [this message]
2026-09-19 6:37 ` [PATCH v5 1/4] perf dwarf-aux: Add die_has_flex_array() helper Namhyung Kim
2026-09-19 6:37 ` [PATCH v5 2/4] perf annotate-data: A small cleanup in __add_member_cb() Namhyung Kim
2026-09-19 6:37 ` [PATCH v5 3/4] perf annotate-data: Allow out-of-size access for flex-array types Namhyung Kim
2026-09-19 6:37 ` [PATCH v5 4/4] perf annotate-data: Adjust type offset for flex-array Namhyung Kim
2026-09-19 16:18 ` [PATCH v5 0/4] perf annotate-data: Support flexible array types Ian Rogers
2026-09-19 17:56 ` Namhyung Kim
2026-09-19 22:44 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919063745.48444-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=wutengda@huaweicloud.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yzhao62@ncsu.edu \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®