From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: sj@kernel.org, akpm@linux-foundation.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, donggeunyoo.kernel@gmail.com
Subject: [PATCH v1 2/2] mm/damon/tests/core-kunit: test the temporal tuner's size quota conversion
Date: Sat, 19 Sep 2026 16:13:24 +0900 [thread overview]
Message-ID: <20260919071324.1583280-3-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <20260919071324.1583280-1-donggeunyoo.kernel@gmail.com>
damos_goal_tune_esz_bp_temporal() encodes the size quota in basis points,
so the conversion is exact only up to ULONG_MAX / 10000. Pin the three
sizes around that boundary: the largest one that fits, the first one that
does not, and ULONG_MAX.
Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
---
mm/damon/tests/core-kunit.h | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 5ff0436c5844..4460dce0352c 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1929,6 +1929,40 @@ static void damon_test_rand(struct kunit *test)
}
}
+static void damos_test_esz_goal_temporal(struct kunit *test)
+{
+ unsigned long max_sz = ULONG_MAX / 10000;
+ struct damos_quota_goal goal = {
+ .metric = DAMOS_QUOTA_USER_INPUT,
+ .target_value = 10000,
+ .current_value = 0,
+ };
+ struct damon_ctx *ctx;
+ struct damos s;
+
+ ctx = damon_new_ctx();
+ KUNIT_ASSERT_NOT_NULL(test, ctx);
+
+ memset(&s, 0, sizeof(s));
+ INIT_LIST_HEAD(&s.quota.goals);
+ list_add(&goal.list, &s.quota.goals);
+ s.quota.goal_tuner = DAMOS_QUOTA_GOAL_TUNER_TEMPORAL;
+
+ s.quota.sz = max_sz;
+ damos_set_effective_quota(ctx, &s);
+ KUNIT_EXPECT_EQ(test, s.quota.esz, max_sz);
+
+ s.quota.sz = max_sz + 1;
+ damos_set_effective_quota(ctx, &s);
+ KUNIT_EXPECT_EQ(test, s.quota.esz, max_sz);
+
+ s.quota.sz = ULONG_MAX;
+ damos_set_effective_quota(ctx, &s);
+ KUNIT_EXPECT_EQ(test, s.quota.esz, max_sz);
+
+ damon_destroy_ctx(ctx);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -1965,6 +1999,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_is_last_region),
KUNIT_CASE(damon_test_walk_control_obsolete),
KUNIT_CASE(damon_test_rand),
+ KUNIT_CASE(damos_test_esz_goal_temporal),
{},
};
--
2.53.0
next prev parent reply other threads:[~2026-09-19 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 7:13 [PATCH 0/2] mm/damon: fix the temporal goal " Donggeun Yoo
2026-09-19 7:13 ` [PATCH v1 1/2] mm/damon/core: prevent size quota overflow in the temporal goal tuner Donggeun Yoo
2026-09-19 16:55 ` SJ Park
2026-09-19 7:13 ` Donggeun Yoo [this message]
2026-09-19 17:01 ` [PATCH v1 2/2] mm/damon/tests/core-kunit: test the temporal tuner's size quota conversion SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919071324.1583280-3-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®