mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hui Peng <benquike@gmail.com>
Cc: jirislaby@kernel.org, john.ogness@linutronix.de,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: fix 8250 hash_mutex race and uart_get_baud_rate() divide-by-zero
Date: Sun, 20 Sep 2026 06:17:21 +0100	[thread overview]
Message-ID: <2026092001-judicial-coherence-46a5@gregkh> (raw)
In-Reply-To: <20260919222627.3797854-1-benquike@gmail.com>

On Sat, Sep 19, 2026 at 10:26:27PM +0000, Hui Peng wrote:
> Fix two bugs in the serial subsystem:
> 
> 1. In serial8250_Label / serial_link_irq_chain() and
>    serial_unlink_irq_chain() (drivers/tty/serial/8250/8250_core.c), hold
>    hash_mutex across the entire IRQ list manipulation and
>    request_irq()/free_irq() sequence to prevent racing IRQ chain
>    insertions/removals.
> 2. In uart_get_baud_rate() and uart_set_info()
>    (drivers/tty/serial/serial_core.c), avoid unsigned overflow in
>    port->uartclk = new_info->baud_base * 16 and ensure the fallback
>    retry in uart_get_baud_rate() terminates cleanly when no baud rate
>    lies in [min, max].

Then this should be 2 different patches, right?

Please slow down.

thanks,

greg k-h

  reply	other threads:[~2026-09-20  5:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 22:26 Hui Peng
2026-09-20  5:17 ` Greg KH [this message]
     [not found]   ` <CAKpmkkV+Gk11x0wCbT1dK8FDraaCb0q=ALS+Tnj0wM+EcMt-SA@mail.gmail.com>
2026-09-20  5:31     ` Greg KH
2026-09-21  1:30 ` [PATCH v2 1/3] serial: 8250: hold hash_mutex across IRQ chain linking in serial_link_irq_chain() Hui Peng
2026-09-21  1:30 ` [PATCH v2 2/3] serial: core: allow third iteration in uart_get_baud_rate() fallback Hui Peng
2026-09-21  1:30 ` [PATCH v2 3/3] serial: core: reject baud_base values that overflow port->uartclk in uart_set_info() Hui Peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092001-judicial-coherence-46a5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=benquike@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®