Re: [PATCH 1/2] dt-bindings: iio: pressure: add Sensirion SDP31

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 20 Sep 2026 03:38:53 +0500
Muhammad Abu Bakar <m.abubakar365@yahoo.com> wrote:

> Add device tree bindings for the Sensirion SDP31 differential pressure
> sensor, an I2C device that also reports temperature.
> 
> Signed-off-by: Muhammad Abu Bakar <m.abubakar365@yahoo.com>
> ---
>  .../iio/pressure/sensirion,sdp31.yaml         | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> new file mode 100644
> index 000000000..fc646eca2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/sensirion,sdp31.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SDP31 differential pressure sensor
> +
> +maintainers:
> +  - Muhammad Abu Bakar <m.abubakar365@yahoo.com>
> +
> +description: |
> +  Differential pressure sensor from Sensirion with an I2C interface.
> +
> +properties:
> +  compatible:
> +    const: sensirion,sdp31

It looks like there several similar parts that only differ in
range.  Would be nice to support them all out of the box.  Fine
to just test on one in a family like this.  If there are more differences
then ignore this feedback!

> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +

Where is the irq?  Even if a driver doesn't yet support all the
features, the dt binding should describe them if at all possible.

> +required:
> +  - compatible
> +  - reg

Sashiko correctly points out that devices tend to need vdd-supply to work.
Hence it should be in the required.  That's not to say in practice it needs
to be in the dts given the regulator subsystem handling of missing regs
is to fake one on the basis the power is probably always on.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      pressure@21 {
> +        compatible = "sensirion,sdp31";
> +        reg = <0x21>;
> +        vdd-supply = <&vdd_3v3>;
> +      };
> +    };