From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Jakub Kicinski <kuba@kernel.org>, Peng Fan <peng.fan@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH] s390/time: use assign_bit() where applicable
Date: Sun, 20 Sep 2026 10:28:00 +0800 [thread overview]
Message-ID: <20260920022804.3145894-1-peng.fan@oss.nxp.com> (raw)
From: Peng Fan <peng.fan@nxp.com>
Convert open-coded if/else with set_bit/clear_bit to the assign_bit API.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/s390/kernel/time.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/s390/kernel/time.c b/arch/s390/kernel/time.c
index 2b989bebd220..3225a66abfce 100644
--- a/arch/s390/kernel/time.c
+++ b/arch/s390/kernel/time.c
@@ -501,10 +501,7 @@ static int __store_stpinfo(void)
{
int rc = chsc_sstpi(stp_page, &stp_info, sizeof(struct stp_sstpi));
- if (rc)
- clear_bit(CLOCK_SYNC_STPINFO_VALID, &clock_sync_flags);
- else
- set_bit(CLOCK_SYNC_STPINFO_VALID, &clock_sync_flags);
+ assign_bit(CLOCK_SYNC_STPINFO_VALID, &clock_sync_flags, !rc);
return rc;
}
@@ -795,10 +792,7 @@ static ssize_t online_store(struct device *dev,
return -EOPNOTSUPP;
mutex_lock(&stp_mutex);
stp_online = value;
- if (stp_online)
- set_bit(CLOCK_SYNC_STP, &clock_sync_flags);
- else
- clear_bit(CLOCK_SYNC_STP, &clock_sync_flags);
+ assign_bit(CLOCK_SYNC_STP, &clock_sync_flags, stp_online);
queue_work(time_sync_wq, &stp_work);
mutex_unlock(&stp_mutex);
return count;
--
2.51.0
next reply other threads:[~2026-09-20 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 2:28 Peng Fan (OSS) [this message]
2026-09-20 16:22 ` Heiko Carstens
2026-09-21 0:45 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920022804.3145894-1-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=svens@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®