mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pengpeng Hou <hppiscas@163.com>
To: wintera@linux.ibm.com
Cc: twinkler@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, hca@linux.ibm.com,
	gor@linux.ibm.com, agordeev@linux.ibm.com,
	borntraeger@linux.ibm.com, hppiscas@163.com
Subject: [PATCH net v3] net/iucv: require IUCV for AF_IUCV sockets
Date: Sun, 20 Sep 2026 11:45:03 +0800	[thread overview]
Message-ID: <20260920034503.17322-1-hppiscas@163.com> (raw)

AFIUCV can currently be selected with IUCV disabled. That configuration
does not build af_iucv.o because the parent Makefile only enters
net/iucv under CONFIG_IUCV. Independently entering the directory is not
sufficient: AF_IUCV also relies on the IUCV implementation.

Restore the IUCV dependency for AFIUCV, as proposed during review. This
also constrains AFIUCV to a module when its IUCV provider is modular,
without changing the directory traversal rules.

The issue was found by our static-analysis tool.

Fixes: c69748d1c9b5 ("iucv: kernel option for z/VM IUCV and HiperSockets")
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <hppiscas@163.com>
---
Changes since v2:
https://lore.kernel.org/all/20260815135456.53684-1-pengpeng@iscas.ac.cn/
Replace the v2 always-descend approach with the IUCV dependency proposed
by Alexandra. Do not carry the review tag for the superseded
implementation.

 net/iucv/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/iucv/Kconfig b/net/iucv/Kconfig
index 5cfddc9c6498..2686d795cc2f 100644
--- a/net/iucv/Kconfig
+++ b/net/iucv/Kconfig
@@ -9,7 +9,7 @@ config IUCV
 	  communication link between VM guests.
 
 config AFIUCV
-	depends on S390
+	depends on IUCV
 	def_tristate m if QETH_L3 || IUCV
 	prompt "AF_IUCV Socket support (S390 - z/VM and HiperSockets transport)"
 	help

base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
-- 
2.50.1 (Apple Git-155)


                 reply	other threads:[~2026-09-20  3:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260920034503.17322-1-hppiscas@163.com \
    --to=hppiscas@163.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=twinkler@linux.ibm.com \
    --cc=wintera@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®