mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] firewire: ohci: invoke all AT packet callbacks from a workqueue
Date: Sun, 20 Sep 2026 16:22:08 +0900	[thread overview]
Message-ID: <20260920072208.GA78337@sakamocchi.jp> (raw)
In-Reply-To: <20260919115017.859169-1-o-takashi@sakamocchi.jp>

On Sat, Sep 19, 2026 at 08:50:12PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> For local-to-local asynchronous transactions, a shortcut is implemented to
> handle the relevant packets in the request initiator's context instead of
> queueing them to the hardware. This may seem beneficial since the
> transaction completes immediately within the software stack.
> 
> However, this has the drawback that the context in which the callback
> handler is invoked is unspecified, as it runs in the initiator's context.
> This makes it difficult to implement the callback handlers, especially
> address handlers.
> 
> This patchset addresses this issue by using a workqueue. All packet
> callbacks are now invoked in process context.
> 
> Takashi Sakamoto (5):
>   firewire: ohci: use workqueue to handle error case of AT
>     request/response packet queueing
>   firewire: ohci: use workqueue to handle local AT request/response
>     packets
>   firewire: ohci: refactor branches in at_context_transmit()
>   firewire: core: use spinlock without irqsave for card split_timeout
>     member
>   firewire: core: use spinlock without irqsave for card topology_map
>     member
> 
>  drivers/firewire/core-card.c        |   7 +-
>  drivers/firewire/core-transaction.c |  22 ++---
>  drivers/firewire/ohci.c             | 119 ++++++++++++++++++++++------
>  include/linux/firewire.h            |   5 +-
>  4 files changed, 107 insertions(+), 46 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto

      parent reply	other threads:[~2026-09-20  7:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 11:50 Takashi Sakamoto
2026-09-19 11:50 ` [PATCH 1/5] firewire: ohci: use workqueue to handle error case of AT request/response packet queueing Takashi Sakamoto
2026-09-19 11:50 ` [PATCH 2/5] firewire: ohci: use workqueue to handle local AT request/response packets Takashi Sakamoto
2026-09-19 11:50 ` [PATCH 3/5] firewire: ohci: refactor branches in at_context_transmit() Takashi Sakamoto
2026-09-19 11:50 ` [PATCH 4/5] firewire: core: use spinlock without irqsave for card split_timeout member Takashi Sakamoto
2026-09-19 11:50 ` [PATCH 5/5] firewire: core: use spinlock without irqsave for card topology_map member Takashi Sakamoto
2026-09-20  7:22 ` Takashi Sakamoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260920072208.GA78337@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®