From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Xiang Mei <xmei5@asu.edu>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, jakub@cloudflare.com,
stable@vger.kernel.org, co+0ea1ac045375cf05@bugs.sh
Subject: Re: [PATCH net] vlan: require the MAC header to be present in __vlan_insert_inner_tag()
Date: Sun, 20 Sep 2026 10:26:57 +0100 [thread overview]
Message-ID: <20260920092657.GB13925@horms.kernel.org> (raw)
In-Reply-To: <20260919154911.642616cf@kernel.org>
On Sat, Sep 19, 2026 at 03:49:11PM -0700, Jakub Kicinski wrote:
> On Sat, 19 Sep 2026 08:45:35 +0100 Simon Horman wrote:
> > > + if (unlikely(!pskb_may_pull(skb, mac_len)))
> > > + return -EINVAL;
> > > +
> > > if (skb_cow_head(skb, meta_len + VLAN_HLEN) < 0)
> > > return -ENOMEM;
> >
> > TBH I am surprised that we have a bug like this in this function.
> > But your analysis matches my understanding of the code.
>
> FWIW I suspect it's because non-ethernet packets shouldn't normally
> reach ethernet helpers.
Yes, I agree that seems likely.
> But I'm not sure how practical it would be
> to push mac_len checks to the callers or anything of the sort,
> so we can as well check here..
next prev parent reply other threads:[~2026-09-20 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 8:31 Xiang Mei
2026-09-19 7:45 ` Simon Horman
2026-09-19 22:49 ` Jakub Kicinski
2026-09-20 9:26 ` Simon Horman [this message]
2026-09-19 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920092657.GB13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=co+0ea1ac045375cf05@bugs.sh \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®