From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AC0A3F1640 for ; Sun, 20 Sep 2026 15:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789917188; cv=none; b=bzNJeKUFsLleugpr3icIyP574bnI7H858Rodp5jug6bWeASNsc9AdtmYW+wDGmlb+WFlTrQ3WbkTKyFYz+vEBC657c3LgNmPX6v41YwA38QGdvnfsBgN435ZXS9H5OuBtuS/ZF0F1hUasbdH3y+OrRoR9gxVHdyKtJYhdlFMrgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789917188; c=relaxed/simple; bh=MlFwPz4d9vi2E9sU5ETxKMIIdJYtsgDWl6iaGrPqkK0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gTyljnuqunR76twp1xteEvrXYuTOB2ik0lLWibpWxEVrbYiwsY+cFJISzjpKfE7SKsMnaTe+pizhXx4x6+sSCobzOn7ntzGh7GduU0/XFnAXcTfyeI8laGexze4ZOj+5/43wDLo3s12f4zVVG2bPxL4rPzstLmpWKDuxLD1CsZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VFZztOK/; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VFZztOK/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789917186; x=1821453186; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MlFwPz4d9vi2E9sU5ETxKMIIdJYtsgDWl6iaGrPqkK0=; b=VFZztOK/6+YWmYkcuVDSkHdpNuXMuhbAPPMNnDB7FaERygl0cpk+YAPX UmBlol111hIuns3AhzcdOtwD2QRSKJ07hFNd6wMEH+b5tjoz01i1GfgMk iK+D4e4DzKobXK4NBAoZVuHsnImx5dcCs8KVjFlY/pxDN+ofs1xV8ZSzn dRLCPNxDd4iw9iakBZTfQYgWu2lAsI290OWC9zT15+fCCem5hWGc/v1Oq VX8Xza7AtADRf8Vfx5iOsY4ePn7JqXCSrvJL6ZVaG1LdUGsGGJmM/ygOR mC8bg5y3mm2vGMi0XK8DO0OqjYhy2Cb6ral3LEitglx9SQaBesGIGrm+z w==; X-CSE-ConnectionGUID: 4liw6yzsTC+hJ97oYVfzCQ== X-CSE-MsgGUID: ncKRwKSAT6WcIILxC9u2HA== X-IronPort-AV: E=McAfee;i="6800,10657,11911"; a="89548414" X-IronPort-AV: E=Sophos;i="6.27,112,1787036400"; d="scan'208";a="89548414" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2026 08:13:06 -0700 X-CSE-ConnectionGUID: f5ZiwFodQU2mHGqLWRt9ig== X-CSE-MsgGUID: CN6fCGa/RLSKypxN3FOeSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,112,1787036400"; d="scan'208";a="3352377" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.244.82]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2026 08:13:05 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, billy_tsai@aspeedtech.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 03/17] i3c: mipi-i3c-hci-pci: Set drvdata before creating LTR sysfs attribute Date: Sun, 20 Sep 2026 18:12:33 +0300 Message-ID: <20260920151248.46936-4-adrian.hunter@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260920151248.46936-1-adrian.hunter@intel.com> References: <20260920151248.46936-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit intel_i3c_init() creates the pm_qos_latency_tolerance_us sysfs attribute before probe calls pci_set_drvdata(). A userspace write to the attribute can therefore invoke intel_ltr_set(), which uses pci_get_drvdata(), before drvdata has been initialized. Move pci_set_drvdata() before hci->info->init() so drvdata is available before the sysfs attribute becomes accessible. Fixes: 884a33131f2a ("i3c: mipi-i3c-hci-pci: Add LTR support for Intel controllers") Cc: stable@vger.kernel.org Signed-off-by: Adrian Hunter Reviewed-by: Frank Li --- Changes in V3: None Changes in V2: Added Frank Li's Reviewed-by tag. drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c index ab595661db1e..af9595009b03 100644 --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c @@ -445,6 +445,8 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci, if (ret < 0) return ret; + pci_set_drvdata(pci, hci); + hci->info = (const struct mipi_i3c_hci_pci_info *)id->driver_data; ret = hci->info->init ? hci->info->init(hci) : 0; @@ -455,8 +457,6 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci, if (ret) goto err_exit; - pci_set_drvdata(pci, hci); - mipi_i3c_hci_pci_rpm_allow(&pci->dev); return 0; -- 2.53.0