Re: [PATCH v10 4/8] iio: osf: add validated stream parser

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 20 Sep 2026 13:12:54 +0900
Kim Jinseob <kimjinseob88@gmail.com> wrote:

> > You could reorder these two functions and call stream_reset from
> > stream_init. Would make it clear what getting to a 'clean' state
> > means.  
> 
> Agreed. I'll move osf_stream_reset() before osf_stream_init() and use
> it from the init path in the next revision.
> 
A few process things.  Strong preference is always for reply inline so
the context is there next to the reply rather than pulling part of
that context to the top of the email.

The other thing is that if your reply doesn't convey much information
beyond agreeing to make suggested change, don't send the reply.
We all get far too many emails and can check the change log of the next
version to see if everything that was not addressed in the earlier
thread has been dealt with!

Note I send this sort of email about once a week - so you are far from
the first to need a little nudge towards more optimal interactions
on the list!

Thanks,

Jonathan

> Thanks,
> 
> Jinseob
> 
> 2026년 9월 20일 (일) 오전 10:31, Jonathan Cameron <jic23@kernel.org>님이 작성:
> >
> > On Sat, 19 Sep 2026 03:24:42 +0900
> > Jinseob Kim <kimjinseob88@gmail.com> wrote:
> >  
> > > Add a UART byte-stream parser for Open Sensor Fusion frames.
> > >
> > > The parser searches for the OSF0 wire magic, keeps partial frames
> > > buffered, checks header length and payload bounds, and passes complete
> > > candidate frames to a registered frame callback.
> > >
> > > Candidates rejected before validation drop only the current head
> > > byte before resynchronizing, so a corrupted unvalidated payload length
> > > cannot make the parser skip later valid frames. CRC-valid validated
> > > frames are consumed in full and classified as handled, ignored, or
> > > rejected.
> > >
> > > Use a direct callback member with an opaque context and keep explicit
> > > statistics for validated outcomes and framing failures.
> > >
> > > Assisted-by: LLM
> > > Signed-off-by: Jinseob Kim <kimjinseob88@gmail.com>  
> > Just one trivial thing.
> >
> > Thanks,
> >
> > Jonathan
> >
> >  
> > > diff --git a/drivers/iio/opensensorfusion/osf_stream.c b/drivers/iio/opensensorfusion/osf_stream.c
> > > new file mode 100644
> > > index 000000000000..e262415e69b7
> > > --- /dev/null
> > > +++ b/drivers/iio/opensensorfusion/osf_stream.c  
> >
> >  
> > > +void osf_stream_init(struct osf_stream *stream,
> > > +                  int (*receive_frame)(void *context, const u8 *buf,
> > > +                                       size_t len),
> > > +                  void *frame_context)
> > > +{
> > > +     if (!stream)
> > > +             return;
> > > +
> > > +     stream->receive_frame = receive_frame;
> > > +     stream->frame_context = frame_context;
> > > +     stream->len = 0;
> > > +     memset(&stream->stats, 0, sizeof(stream->stats));
> > > +}
> > > +
> > > +void osf_stream_reset(struct osf_stream *stream)
> > > +{
> > > +     if (!stream)
> > > +             return;
> > > +
> > > +     stream->len = 0;
> > > +     memset(&stream->stats, 0, sizeof(stream->stats));
> > > +}  
> >
> > You could reorder these two functions and call stream_reset from
> > stream_init.  Would make it clear what getting to a 'clean' state
> > means.
> >
> >
> >  
>