From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788A633937F; Sun, 20 Sep 2026 18:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789929671; cv=none; b=sfIlNYzXUE5JulNQ60dmu2DD6UcNqvOq6nEcsdAYJaaAGTYboGzMjdmqIGDmKOk/Gdw0sNCGZEmRU1wTd72oUtulVpW5XuUCppz9ulg/bv1TOiupV3NWOKdWlL9ZQl10fhbauzO4v3/2n9E2LNsVc2YLeEVBZOBNBsAQANeEw3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789929671; c=relaxed/simple; bh=llEUnHrKs9cjv+MPPjnNkF5WjNjcSKzl7eS2euLRkpM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PAR8t9Sp7nqAIN9FnLnuXpKot2DTeF8ChO/i8WpIFiQgmcyTBgt0ECR7AFBLMCkrE3DhDUVbveum6nDerww/KNGHdkRPjlUA4d3GdCcyDYPkKttJbxAzjaRYrXCZQJ6vNAZDDqc7+2xsHDDxlkS+NFoh6GF2W4DG7vtDcbxJOwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JvGEpDQs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JvGEpDQs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 525271F000FF; Sun, 20 Sep 2026 18:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789929670; bh=JtAYMMeReGVfPY8o1Ov5RtC3owFWBfDJ+FT3y9mAGk0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=JvGEpDQsYQJqqO/wOSz9KmEjw5aoVgvZ2tIYBpw9YErvyLYykXtS+l7NoIQ+oD0Dz 8pGKZH4MwDv/BxgoFaomf00GHeT/VWy5LrJNUkf0ZT3exG6vCXVODeGqPkklZXlQEz nsBXtixqRdtJtDPEMIB9e8ejKfxIJaatnGbBHBNnCrFJqe+LZkIfjMJWwuYkNiev50 TbdFSbwEdh1soDTNjkY0XhjZzkPwzBIc5X7hPauQ6tpwwv4l/Y4D4mM77emItKvXT6 6RJbYRHcgO1pixpuVpQXvOflUMYntSQw+o7kMGfoOzgyHaFw01Hi2OdWV11/FSqJ8K 4+fY3opppoTvw== Date: Sun, 20 Sep 2026 19:41:07 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: Arka Mondal , Nuno =?UTF-8?B?U8Oh?= , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, arkamondalofficial@gmail.com Subject: Re: [PATCH 0/5] iio: dac: ad5758: fix DMA alignment, raw range, offset and 4-20 mA Message-ID: <20260920194107.12173789@jic23-hlaptop> In-Reply-To: <5cd6b31da1f8cbd5b004888cb0df22061fe86a2b.camel@gmail.com> References: <20260918122032.134947-1-arka@arkamondal.net> <5cd6b31da1f8cbd5b004888cb0df22061fe86a2b.camel@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 18 Sep 2026 16:22:27 +0100 Nuno S=C3=A1 wrote: > On Fri, 2026-09-18 at 21:20 +0900, Arka Mondal wrote: > > The first attempt to send this series on 2026-09-18 was rejected by > > the kernel.org mail servers, so it did not reach the lists. The patches > > are unchanged. > >=20 > > This series fixes four bugs in the AD5758 driver, all present since > > commit 28d1a7ac2a0d ("iio: dac: Add AD5758 support"). The last bug > > takes two patches, one for the binding and one for the driver. > >=20 > > Patch 1 marks the SPI receive buffer __aligned(IIO_DMA_MINALIGN), so > > it no longer shares a cacheline with other driver state. The 2022 > > conversion of IIO drivers to IIO_DMA_MINALIGN only changed existing > > ____cacheline_aligned markings, and this driver had none. > >=20 > > Patch 2 rejects raw values outside 0 to U16_MAX. Writing -1 currently > > gives full-scale output. > >=20 > > Patch 3 fixes the offset for every range that does not start at 0. > > The +-20 mA range reports -32 instead of -32768. > >=20 > > Patches 4 and 5 fix the 4 mA to 20 mA range. The binding and the > > driver give it as <4 24000>, which is 4 uA to 24 mA. The data sheet > > (Rev. B, Table 32) and the original text binding say range code 1010 > > is 4 mA to 20 mA. The old value is still accepted: the binding marks > > it deprecated and the driver maps it to the corrected range, so > > existing device trees keep working. > >=20 > > Compile tested only; no relevant hardware available. The binding was > > checked with make dt_binding_check and with test device trees: > > <4000 20000> and <4 24000> are accepted; <4 20000> is rejected. > >=20 > > Arka Mondal (5): > > =C2=A0 iio: dac: ad5758: Fix alignment for DMA safety > > =C2=A0 iio: dac: ad5758: Reject out-of-range raw values > > =C2=A0 iio: dac: ad5758: Fix the offset calculation > > =C2=A0 dt-bindings: iio: dac: adi,ad5758: Fix the 4 mA to 20 mA current= range > > =C2=A0 iio: dac: ad5758: Fix the 4 mA to 20 mA current range > >=20 > > =C2=A0.../bindings/iio/dac/adi,ad5758.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 ++++ > > =C2=A0drivers/iio/dac/ad5758.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 18 ++++++++++++++---- > > =C2=A02 files changed, 18 insertions(+), 4 deletions(-) > >=20 > >=20 > > base-commit: 08df884136f1c1197bab2a27814404fd329d9aac =20 >=20 > LGTM, >=20 > Reviewed-by: Nuno S=C3=A1 Other than the one thing on the dt-binding that is more policy than anything else these all look good to me. I'll wait for that to resolve though before picking these up. Thanks, Jonathan