mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Hui Peng <benquike@gmail.com>,
	michal.pecio@gmail.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: fix descriptor parsing OOB, port/bos locking, and devio/ledtrig races
Date: Sun, 20 Sep 2026 06:12:57 +0100	[thread overview]
Message-ID: <2026092024-illicitly-battalion-852e@gregkh> (raw)
In-Reply-To: <0bc9c10f-6b6e-429c-a625-d34b12aaf2ef@rowland.harvard.edu>

On Sat, Sep 19, 2026 at 10:21:33PM -0400, Alan Stern wrote:
> On Sat, Sep 19, 2026 at 10:35:18PM +0000, Hui Peng wrote:
> > Fix multiple memory safety and locking bugs in drivers/usb/core/:
> > 
> > 1. In usb_parse_ssp_isoc_endpoint_companion() and
> >    usb_parse_ss_endpoint_companion() (config.c), check remaining
> >    descriptor size before dereferencing desc->bDescriptorType or
> >    subtracting desc->bLength.
> 
> I have lost count of the number of LLM-generated patches we have 
> received trying to "fix" this "problem".  Try asking your LLM whether 
> this change is really needed.  (Hint: It isn't.)

Yeah, I've started using it as a "test" of new llm models/frameworks, so
far they all fail on it :)

Hui, please slow down, learn the codebase of what you are submitting
patches for, and the development process better before flooding lists
with tons of patches.  That way will only get you ignored.

thanks,

greg k-h

      reply	other threads:[~2026-09-20  5:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 22:35 Hui Peng
2026-09-20  2:21 ` Alan Stern
2026-09-20  5:12   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092024-illicitly-battalion-852e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=benquike@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.pecio@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®