From: Greg KH <gregkh@linuxfoundation.org>
To: Hui Peng <benquike@gmail.com>
Cc: arve@android.com, tkjos@android.com, brauner@kernel.org,
cmllamas@google.com, aliceryhl@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: restrict BINDER_NLGRP_REPORT to CAP_NET_ADMIN and fix binderfs minor leak
Date: Sun, 20 Sep 2026 06:01:49 +0100 [thread overview]
Message-ID: <2026092030-surrender-appointee-2f52@gregkh> (raw)
In-Reply-To: <20260919213654.3317464-1-benquike@gmail.com>
On Sat, Sep 19, 2026 at 09:36:54PM +0000, Hui Peng wrote:
> Fix three security and resource-accounting issues in `binder_netlink.c`
> and `binderfs.c`:
>
> 1. In `drivers/android/binder_netlink.c`,
> `binder_nl_mcgrps[BINDER_NLGRP_REPORT]` is declared without `.flags =
> GENL_MCAST_CAP_NET_ADMIN`, allowing any unprivileged local user to
> subscribe to the `BINDER_NLGRP_REPORT` Generic Netlink multicast
> group and monitor system-wide binder transaction error reports
> (including sender/target PIDs and transaction metadata).
> 2. In `drivers/android/binderfs.c`, `binderfs_binder_ctl_create()`
> allocates an IDA minor via `ida_alloc_max(&binderfs_minors, ...)`,
> and if `d_alloc_name(root, "binder-control")` fails, jumps to `out:`
> (which calls `kfree(device)`) without freeing `minor` from
> `binderfs_minors`.
> 3. When the `binder-control` inode (`device->context.name == NULL`) is
> evicted in `binderfs_evict_inode()`, `--info->device_count` is
> decremented even though `binderfs_binder_ctl_create()` never
> incremented `info->device_count`, underflowing `info->device_count`.
> Only decrement `info->device_count` when `device->context.name` is
> non-NULL.
Why isn't this 3 different patches?
thanks,
greg kh
prev parent reply other threads:[~2026-09-20 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 21:36 Hui Peng
2026-09-20 5:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092030-surrender-appointee-2f52@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=benquike@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®