From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 752EC49DB85 for ; Mon, 21 Sep 2026 12:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789995532; cv=none; b=Mw7p2y64IDkdrEse4mzjOfDcKS6xlm5fKRpPJMsDuYjIp0EsJz7f8bwxwGmAvVdfK7gRqp1rcgnH4xHLE4EIyJfvUf1lg32ytajU8ji7Sbb3g8pseOHNsP5q2KTkpCx7Pq1VA9+atZNKh+YtTxeM3jvCerd2NKw9h5SL6EWbnQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789995532; c=relaxed/simple; bh=+q94hW+kiltzd6oZ8H14oSSW0osx3J/1PTA4e8Zi7ro=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PGFsOagoAMaHcFcYxocRdJOXUuZXZp6jRR/Nya7CgyLXA0eznn4Sguj+ROxTmnKxzSV0nAkr8XjdJAgPOFY/F+sIVbI7I3aCepZ15BL120ggUzMNOx8P9lT+lvlfYAtxBt6xo0uS70YMGNS77Rsq5GIIZG3+ygGTUReYKmDP4sA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DLwFlDpR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WtQYeD28; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DLwFlDpR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WtQYeD28" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68LAdt1S2091243 for ; Mon, 21 Sep 2026 12:58:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Apr68ly3hCT/cD0oaIKI9KYaRUniJ63SnCFjliTBbmo=; b=DLwFlDpRW/YNzVdw FrHwNY76mp+N7QpoKx6XjiIMj+bHc/lGGJOFv/TmqZ0irmg/6eeoCYt5A6Y5md3I FMdc12l1NRMvxfhLAc1+4U/tLmE1m44M3wZ2mGZr4fb8krMYU5TtXTB4KPc0oTOH TQ0Ue3b8XDm6Njo9s8Ti2ndheVp51aiMasLCIBKi5j9+gTKExf3Xoxxh3P3IyeUo ukTFagyvxke6VVUPTo/0hBFk++fybmYEH1DGz60EDcmZZZuI2+uAZnSQVp6EgWoE gRjvh96KXHn8ipuW32lth8Bx7+KG4RoqKX2rvw0crvHGc8sri4zWo/g7f10To+Et KqMhVQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gtt3wteh0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 12:58:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93a1bffc2eeso243546685a.2 for ; Mon, 21 Sep 2026 05:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789995528; x=1790600328; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Apr68ly3hCT/cD0oaIKI9KYaRUniJ63SnCFjliTBbmo=; b=WtQYeD28hWqD5bBRBHAAX43ZMr4RyaS/YnS1cZpP62EJ/cCVcd2VmcRkhxyqatyAp7 XMNj4/LgKio2ARiAuoZZ+dUsumcmMJWUdnHJ4e6FxtvAQy4v8jjdnOctqHgFJJs1OqTF nTMEZQBKjI9LAraqRLR7Xu4+roFUcAqaH7bT8iqE8wxhwp5DfA6UudIGrcHGmWwt7ehm wznXRzP+HsOQ85cvRu7lRyjWBb3TOe6ipUDdfb6gpGCFJfKxZtcHRwh1luFppLT6XIVN lpV2stdLERCImH5oT+N1IPgSFLsTnuG0adlve1LqIEAv9iWN8vVKayIHMRc/uKnOMtu0 bIFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789995528; x=1790600328; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Apr68ly3hCT/cD0oaIKI9KYaRUniJ63SnCFjliTBbmo=; b=RVSJ7+/oGE9WIdabcgG8IrBkTiXNJjqSa/v09+y8sKeTMa6Ocr0Dm3rkIb6gXUz0vn OvzQ5hYJ4gYQVBREXLGDx0WnE1wp8IcUv5rlOjyoDkXYViN7TnYkU62XxngTqJdlZMKI oBoAOd8NM8+wqPcSyNeTVBG/ll1Q32v35CIj1mQNcU/WAmjTNmQv6Vl4hN/2ZZZGHVzx 52IWprHdEOI0OmweKBn7BeMbB1hHZFu4UcRlTQHDCR36o2cwc57spYu7UT7niNNqx1Eu VgVVSVCgIvL7ViCiuwwxvbS7fLRKpMUh90JPXaONMPKsbsYTkGTP3Viaqm88TfsEtGE+ UDcA== X-Forwarded-Encrypted: i=1; AKwUvBz7P5MDU7Ky/yNXtyxxVD9izDmZZfypi1Wvgu3c1a+vvCUQjp+l8cM+gyod8/cXwH9iURd9xfZ6yJgjabU=@vger.kernel.org X-Gm-Message-State: AFuF++lLTn+voVYsoQl0DdwpP5ChUUEFab85y2qp5l6aZVm3uNIkUD4h awq9AtgRqDBCLHg21E0KYATy9faCftCy5xAQs9lk07akG2kFfEDczXaMf7evDHZpAWYauTVMSJ4 qx91gO5fAhERLRzl/afQM/ztbGne2IfQNmwlYhvmNOF98VhrTI0LkYLaqVhvzSn/hKNg= X-Gm-Gg: AYBFou2X4HHFCyJFKqrh6TGDSA6LswhuQ6vXwaKRjG9iXFnqsKJmBGNeSXOC1UwuptC w3CUBbc61O8Py2HmZFLmpSxuECOKxFfS5nxqhKPnEL+9iPZEZWT9cwzAOjtCTxlONOi2Tlx5oZM pDQmPIRDdZot/pCbr5oHo3DNsHGmAjemtLr6EdS63FmfVHyMGay8lZ8Ksi9ZDnAKqGSuIED+9LE qCzSwkC0AvsUICGD1HaI2PK3MEJIUwBWiB+/ZP4Mw5LFmk9gfeg/ruhpQfU3gngRscdPdniHjyv eiWCOTV/svE+V+B/C5DaZ8WNRmAkxTFM/JKpnHfa5NM624XKjhN7o/ceV9vyBrmxKyriem5Kc0F W3Kmym7UU6XIRLIF8JEriQcGBxb8= X-Received: by 2002:a05:620a:288e:b0:93b:c279:2fc9 with SMTP id af79cd13be357-93c15dda27dmr44779585a.30.1789995528601; Mon, 21 Sep 2026 05:58:48 -0700 (PDT) X-Received: by 2002:a05:620a:288e:b0:93b:c279:2fc9 with SMTP id af79cd13be357-93c15dda27dmr44776785a.30.1789995528174; Mon, 21 Sep 2026 05:58:48 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:d04:d483:faad:1e4e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a359037aasm320278766b.63.2026.09.21.05.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 05:58:47 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 21 Sep 2026 14:58:14 +0200 Subject: [PATCH v8 05/14] crypto: qce - Use fallback for fragmented skcipher payloads Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260921-qce-fix-self-tests-v8-5-107537869a72@oss.qualcomm.com> References: <20260921-qce-fix-self-tests-v8-0-107537869a72@oss.qualcomm.com> In-Reply-To: <20260921-qce-fix-self-tests-v8-0-107537869a72@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio , Russell King , Abel Vesa Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2137; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=+q94hW+kiltzd6oZ8H14oSSW0osx3J/1PTA4e8Zi7ro=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqsSntalv0A4u6x2wLiP9tsPe+bVnenmBnDZTEi sFO8LmZ366JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCarEp7QAKCRAFnS7L/zaE w+GQEACZttwFyotUQKFljDEyRe4igLp/89tHuFhol7EGvNxkCWVOkE8o0dIGGtgBzFlEZyH+Ren L2XNBJgH7KZxrEZw4txDVrX6y+dODBQ6467be1+9uuS5Ekn5vrtcIRLfGP+uBXa/TfoYXHR7uoj g+wbS1siKhyY7aA1clGthUFIpIglEgZ8BymfhP3coggLql9HVFTVIBPbwS0DY0df6T7/UVj50rF Uz7gS2+gz1TGqDXoTNyXNseiztBjWyVnGYQ+JfGelyA5qbJGjNDQtoMHzBB0WYdmjuzFlLCgrFn Npdhk96sesIt+0dnTTwPFur+M4RmM891qHXDaOtCFjrQmtG0driYLTLOXE+wDW2C5quDaXgoJSz cbLi6Hh87+HwAlIiriNOVyw+QZ68KugFY22VGpklYM5BN5IATNXmA1GhaG0LEUTUl7HOpDytxja NJJzPj4PCafhxMcX6YksGhA/1uhLnFf4HWgxzAwJWZnCo3Zf3t8jAtN7bWY09YxaKjpLEgb3+7c ma21hCkFl7pu9gsNgjPbgVdDQ0vbFe9hNMs/tkYm2ckq+tqmaKK5uj11C8m4Fl9svSfIeLhHB+8 3vW1Yw9A34S39gu42KjICzuHKmvoAoQKcO4GlCOgKvizSKjiVrVuXmy+u5Jvr+o3Xwhppx5Idfw sMiF+eju8KO3Tbg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDE4NyBTYWx0ZWRfXwg/4CNwqDkIf sTNXWsBVTZZso9Bb6o1eOumSdOQyuhOu22uC16BELgfddnJE6lUJpU1vEuPhILxmQKpvNGjxUQg 4GYF36gxcK1KibzS++KelNr87S04BYW3NFqQrZf3X+k9LylklfAFJzTeoHqnWRH52WviLC6SCSr 43UvMK1JIlOQ/oXntTWW6qw9URWBei278cFtY8Bm/hN2pRSXuO/vDug6TWhBnA1rSkGD1We3P1D i9DXf1LRsisBZYmamDakQ29QVKu+D0GKqqFN37cV6YWU9q4S2OU2tBMdjiCMgcGo5BT55B4Dpsf CzTlN+WiRuejm5AmmT7jZolARSs4W8QLmjeFocioIxJHj8aOgJT6vidtOXWs+92r2IlGEbllJJs RdoMG/Yvpsz1pQAX2vm+JJgdGFj+0sqzs3LuvGVV+PQ5uwjTpiSZR1Qf9muRwc6dTV5fbTeNljh id2BF6QLM0CrCyrqQHw== X-Proofpoint-ORIG-GUID: kHBIXmd6g5h69ra9pH-ickFTKn-v1nAZ X-Proofpoint-GUID: kHBIXmd6g5h69ra9pH-ickFTKn-v1nAZ X-Authority-Analysis: v=2.4 cv=dakVTnXe c=1 sm=1 tr=0 ts=6ab12a09 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=2ArJjka39wvl4ErYtigA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDE4NyBTYWx0ZWRfX4Zl8DXOcVbGY 1lgyndfmW+0v0koiD1mq/zTUzWpxDmFf8gEOeIKsozxGzQAJ5A1UbRroZkYA/tg00fOjfclQ/lF /pHl1mzMkFnM16rgm4FWDucdVCu+Gas= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_04,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210187 The crypto engine reliably processes AES requests only when the payload is a single contiguous buffer. A payload split across multiple scatterlist entries makes the engine stall waiting for input, failing the request with a hardware operation error. This was uncovered by the crypto self-tests, which feed the algorithms randomly fragmented buffers. Detect a payload that spans more than one scatterlist entry, in either the source or the destination, and route the request to the software fallback. Cc: stable@vger.kernel.org Fixes: 25b71d61d631 ("crypto: qce - Improve the conditions for requesting AES fallback cipher") Tested-by: Kuldeep Singh Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index e2ca2f7a6eea1129edb724fe30659d55aaae8190..4b7545e6aed220b7fb5af7dbf20ab47db5d1d180 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -261,13 +261,17 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) * needed in all versions of CE) * AES-CTR with a partial final block (the CE stalls waiting for a full * block of input). + * A payload fragmented across more than one scatterlist entry (the CE + * stalls waiting for input in that case too). */ if (IS_AES(rctx->flags) && ((keylen != AES_KEYSIZE_128 && keylen != AES_KEYSIZE_256) || (IS_CTR(rctx->flags) && !IS_ALIGNED(req->cryptlen, AES_BLOCK_SIZE)) || (IS_XTS(rctx->flags) && ((req->cryptlen <= aes_sw_max_len) || (req->cryptlen > QCE_SECTOR_SIZE && - req->cryptlen % QCE_SECTOR_SIZE))))) { + req->cryptlen % QCE_SECTOR_SIZE))) || + sg_nents_for_len(req->src, req->cryptlen) > 1 || + sg_nents_for_len(req->dst, req->cryptlen) > 1)) { skcipher_request_set_tfm(&rctx->fallback_req, ctx->fallback); skcipher_request_set_callback(&rctx->fallback_req, req->base.flags, -- 2.47.3