From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BA4B4C1515; Mon, 21 Sep 2026 15:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005999; cv=pass; b=LP/zImgL4OesseytXtggH5hvThojgPvOMQS1ntfgpkhWztRNxW0YxGDVnUVPkC6pUaMERNKOcLzry6YnkPSD0++QxzBPaD6xXQuMfG2CK5LBdfn58VZGwAuO+CnQNH3cSwdpVdliV1TKpB4BFjMNWBctLfB+hAtyLHZRw68HYLQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005999; c=relaxed/simple; bh=TBPexhzayAdH9jIT5ry4w25OQZ3HIU4oyIxANtSCtg8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UoIuYVB9PjLzLXqz7kP696DdZtF1LgCfD5ynUqKwA/tFBFOhr8v/UXLcJ3qjAhCRmx68usUStVVOtZ1fscw0rtBgh4HdZDBIU2AgB7JkU+gQKbLS/qN9Vm6E7qYTQNyD1FMkFrV7WamT7VniUMqQGwGg8lLZguLz1OW1n2Ry8jw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=VEQ3WRT9; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="VEQ3WRT9" ARC-Seal: i=1; a=rsa-sha256; t=1790005939; cv=none; d=zohomail.com; s=zohoarc; b=dL8QWo0f+z20HLw9HXd7aGFStuR/k/6l/FzgRHplWzXjfpgtJuClsAOR1DZ512xYHu8NCCcCazC2nApnrzpzPNhdvceP+z1X78p38mpx60wgUMZkUI/Ao4mFSgQSZWorMd1ffR8UsjM1jflS2DFrKLxXRt8gVLx0LlB0uhVfp8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790005939; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=hVfhbzvE6GURebcBrX2O4AYlNWe76f6ylBqD+StMY7g=; b=HJFIqM47xYTMuV3pj9MXTVTK4CKFU/hv8W2mvG3UieaVb+Aop621PPBOBihh5WJDCUee+UI0PKD4Gv+dDnq8qmUosBaFflQN+2gn0bkgxMK+bpL9G6r40GTtnFb5uxzfQKdVT490HXiNrokbN+diPmvlgRv9vnVIZdseXXec0h8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790005939; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=hVfhbzvE6GURebcBrX2O4AYlNWe76f6ylBqD+StMY7g=; b=VEQ3WRT9ZruGE+auQHYNi5JDxIAHiWLc38gvCVDu8IEpeZkhjV7guYnBbNvapKlB kuVL8L0Gg64ALMxnI3i58j7hSNJD8ia9h5AwssgPQFL5iEcXmYjvii55IRXKLDqb4Mb eUk+zgTbkKwFy7EiaiQoctyHlhWRtM0LJzTWf/Vg= Received: by smtp.zohomail.com with SMTPS id 1790005938404198.15695800259266; Mon, 21 Sep 2026 08:52:18 -0700 (PDT) From: Nicolas Frattaroli Date: Mon, 21 Sep 2026 17:51:29 +0200 Subject: [PATCH RFC 03/25] drm/atomic-helper: Set mode_changed on vrr_enabled change Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260921-vrr-limiter-uapi-v1-3-2fcd7d011646@collabora.com> References: <20260921-vrr-limiter-uapi-v1-0-2fcd7d011646@collabora.com> In-Reply-To: <20260921-vrr-limiter-uapi-v1-0-2fcd7d011646@collabora.com> To: "Borah, Chaitanya Kumar" , Leo Li , Daniel Stone , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Helge Deller , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, Derek Foreman , wayland-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 A change in whether VRR is enabled or not on a CRTC will be of interest to any VRR implementation, as they may need to recalculate certain internal state in response. So far, this was handled ad-hoc in the drivers that implement VRR. Handle this in the common DRM atomic core by setting the mode_changed flag when this occurs. The rationale for using mode_changed is that VRR is deeply intertwined with the current mode with regards to its timing. Consequently, any component that cares about a mode change is likely also going to care about VRR being enabled/disabled. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/drm_atomic_helper.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 9d006f98413a..0664d5779282 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -694,6 +694,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, new_crtc_state->active_changed = true; } + if (old_crtc_state->vrr_enabled != new_crtc_state->vrr_enabled) { + drm_dbg_atomic(dev, "[CRTC:%d:%s] VRR changed\n", + crtc->base.id, crtc->name); + new_crtc_state->mode_changed = true; + } + if (new_crtc_state->enable != has_connectors) { drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch (%d/%d)\n", crtc->base.id, crtc->name, -- 2.55.0