From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E07A8635D for ; Mon, 21 Sep 2026 01:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789955309; cv=none; b=B/OlpoH5LBe23m8uoDZJvSeBByUgXEtXIqeJtMwOJEw/91zRTOXF+/ZNkxv4R2E7Eru3x2kZcSHazE1mcw0So14QyDP7ho+aeKYOS/igrmVVTPEop2EuwjTSbUXEJT1fvek7rtF3qJe0G4gWRpiJTgxNtgciyAWrVOaYAsGKgzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789955309; c=relaxed/simple; bh=NokCmnDavm6nge3ht4581Wl5cd5odu08TSzfjqYvPX4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fNy27Gj2993eCZMNsC7byz4QCe1Gk0W9sa/W8/pN2SJSI2NwowwXgHkHpi7r7svu0kVQLjt8cgl2Sw31bl3qpVfZAnpQ80gIi1rhsRozLedJ+yYG6EqpBX6DcGUWrMk3OoH/OBjQvMqX2Nh1BlC8nCkbZ+IPLaBR6csl5L0lCtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lT3ZlwYb; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lT3ZlwYb" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-398a1676000so1947056a91.2 for ; Sun, 20 Sep 2026 18:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789955307; x=1790560107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d9cRyT3K2PGM0R80JNPC3Ark3l212LTWXq1nqw71ThQ=; b=lT3ZlwYbPNQga3Ai3VeFDR5UFHMxyif46XNA3HB7rBBE/XDS+csJ7IjY9hugVC/OJd qdX6qfS0VzCsCmnxWutLYDB3en5jERq9jcu8TIia0TfCBcMYeB/1/8yhMDop+RnqBkO5 w11hNvkJ3cUMvMFuLwiXggZppOsGIZrEW0ukBkbkU3Lo1fkTdrB/9fsgH/uvNKSCPHLw 0VCINAUzp86WNvooMKfkqvbJ0zIXMBU8wJO12asWCWfJ3t/WaWxTUQxGBCIalR4oKT9H XOe+xGd5zTTI5dkynt4/7NUPdrx2J5rj8nY6g0h1J8Bu+SlbduWb034pxUDrwRG873Hb 5KVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789955307; x=1790560107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=d9cRyT3K2PGM0R80JNPC3Ark3l212LTWXq1nqw71ThQ=; b=hnEzO5T+0t46l2micbgnECtJmda59B3knoLwwhCTibmTGwnvAov1qfh4vGP2SbbV8g U3jOIiy+19lRxkOUQp8xS8JoStxP7trX0bZlLHIvN29CcNVjsr2pk2nCOu6w/15w736a Zui5SKel2o/5PHDDAQQ30r5L7FSnv2Sj1ny6KWsV4bhaLfnp5KGEio4mNHTt3/uK81xe JdDFXFWNm3OtkSTArJ4GV3Vz5sxS6A/R6jfcXZuh8pSviDJR8qVjw7jZ1g+/j77x9EZt Dr2lnn57qZwUj4o92xLpZ27G6fyDo+hlybodOKs5SrrnPTQGml8ClsoO/fN9R1VFxLso O3ow== X-Forwarded-Encrypted: i=1; AKwUvBwFtud5PjAbRTGZilYhIpZbjunQUj2+7F90M7MRfyZsMlAPvHufovhSRFvSA2z5MRKpqsAZOaWnld9fhLg=@vger.kernel.org X-Gm-Message-State: AFuF++lnirB8KRTvN6TiA/uCtGV9iF0QBNE3jFRgUg7npAYdScn4L9Oo V0wdFSrGHVNIkMDgJjKvkranoAdsNEFHGr72mwXbtgRcnSf9rfAFrVwH X-Gm-Gg: AYBFou0WCWz11KILmMTakptyxDpGs6qFujvU16nuC0gHDnqH6zDcwaYVEtl+Zev1iGd ySD+6ldVVRzdS/71HRUtEXkbkQiTKbwmYECKpqXc2kUST3T+ia/SjmE6m8yqwLpjkvib5wVO+qS g5NGtQUut7p7IEsMMQ5YjMmVKbShe2otx2gaJ8NXGU7wg+0mFhzVZjLwflKGDlu4h3ny/P+qs8b s1Ewc13+TMIdb2YRH9GU9TQkhBGo5WiYvJjBhI8hqaevHddmOXZreF/duiDJsbgEarqyXJQeKnx YXUubprXPlvCYknyKjdglqXLd+7XXSe/Na6ZLH4xKs90Og8C7Nm9JECW68pVHWbjByPWXVlvoT1 qgpeVTsWHsgd4qP29Cwmwx7LCS6J0m/M5z5IXXQ91h3tsoHBortvkylbaV6sxgJkfrXQb5bp0/N sagMDWPw4WJkK0xHQZ9b7x/95jEcTbl/Cv7S1QknHjct5fSxbH1cBTECUbX6ufE4tYzmThaeIrp pMeiZYH7EIRG8ekjDR2ahPKVEF1FSg5cs0iH0QZeFq/70WKa8HnrsVDv7IF7FChA3dLDw6mGGyh r/9jC1oIwbW+wh8idF6+kg== X-Received: by 2002:a17:90a:c105:b0:39e:4c80:f67e with SMTP id 98e67ed59e1d1-39e54f11f69mr15842285a91.29.1789955307433; Sun, 20 Sep 2026 18:48:27 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e6c3145dasm11345650a91.4.2026.09.20.18.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 18:48:27 -0700 (PDT) From: Hui Peng To: Greg KH Cc: Hui Peng , valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usbip: validate ISO packet descriptors and URB lengths in vhci, vudc, and usbip_common Date: Mon, 21 Sep 2026 01:48:25 +0000 Message-ID: <20260921014825.733805-1-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <2026092058-obtain-angles-cb4c@gregkh> References: <20260919223519.3890269-1-benquike@gmail.com> <2026092058-obtain-angles-cb4c@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, Sep 20, 2026 at 6:18 AM Greg KH wrote: > > > diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c > > index 100f8920624b..8bd9af7ebfc8 100644 > > --- a/drivers/usb/usbip/usbip_common.c > > +++ b/drivers/usb/usbip/usbip_common.c > > @@ -482,7 +482,6 @@ static void usbip_pack_ret_submit(struct usbip_header *pdu, struct urb *urb, > > if (rpdu->number_of_packets < 0 || > > rpdu->number_of_packets > urb->number_of_packets) > > rpdu->number_of_packets = 0; > > - urb->number_of_packets = rpdu->number_of_packets; > > You are removing this, why? > > How was this tested? > > greg k-h Apologies for the noise, Greg. We originally found and tested these ISO packet descriptor issues on 6.18.14, and when rebasing onto mainline we missed that commits 2ab833a16a82 ("usbip: validate number_of_packets in usbip_pack_ret_submit()") and 4f8d24c48101 ("usb: usbip: validate source and destination offsets in usbip_pad_iso()") had already fixed them in upstream, which caused the rebase conflict in usbip_pack_ret_submit(). Please drop this patch. Best regards, Hui Peng