From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94D0352003 for ; Mon, 21 Sep 2026 04:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789964716; cv=none; b=MlnEJ0AIPrnAqYCmMylIJpbwT+m8oY8SBdPls8R+1CtiQS42EZo1cMeSkc7WRNOFd/1PkDLHLQCAjiNUx5oSlgut350aAuFvPJCm3mIwVftQz+5Fm2HOPF782zLUviagZi2eoBnMGosRGT7MK2YFziiizLbqfh/9IW4TI3xgPYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789964716; c=relaxed/simple; bh=edPMpW5yt0f3Pp1wWdYZRCncoquv6QtazaRW2PBcM0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wloy/iQY8vCVT/b7z596PZPZZXL4wCzL6wA4IuTyv1w0L9zVJ3ufQDOfwBL44mONG9Y2p+Y2YGEP9je2zX4XYAo/BDziEVOklltzjEWWJG8zfSvGwk49efXxV0+JG2ePn+2DxCe8UwTOCwhdgF1u5eaBIYxWGqDWNU3uzin8EPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IDHcmhjO; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IDHcmhjO" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cea4c79fso1021209a12.0 for ; Sun, 20 Sep 2026 21:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789964714; x=1790569514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rvbp9qGSwfhr03W/yIMn0HJVEki14kXp792hr6doGSA=; b=IDHcmhjOeqA9LKZxupt1+EHFaEQ4VPavHtcwvuONJb4v1W3DNbtYmOjFXqpY4lnqVK lKaCktqKye179+5TAgi4/qSdl5dj88Oht4V4mWciYepytjmhDX5kz1c8kAYybjjMERxs HboaE1zOgnNDH1ulHITGiXrUIVxV6XsUm/HnLFcdV1Po6GWaovIjmg81W+c4vpqAWdOS NiSANm4Poyww0uGA87Gm5X8POg2ZY2wsRJ2Vn+ThMmRgmYtW9hM540M1MGTadjRWatry YWc10Pqmg9JrjA1OV3gjQywwCTqgw36iK9PwpLZANHwXKattLKcA9fpdhNTou4jEFBFi iPYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789964714; x=1790569514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rvbp9qGSwfhr03W/yIMn0HJVEki14kXp792hr6doGSA=; b=m9RyX0WyfEySW2sibttWCVKmxEzHhbObIzZo8VKdKkKQAJjQQHu29LFAesgABvTHPH gREdgcdgkpi4A6e0tUgjtRI5CF1Xsug0rF8cm3wDiGF3MVocSVDwoIBjSLV7K2BE3e+b zn449B8vcS3QLqAeQdQaUUyKFA0h4wVHYTBj7xmc+F2tO1XOL8YJkmH0EnfeMbPKvZnM L8bPvRFb6WCkWswCOTZEHQ68w/8c99SITZXDQzj26hsdqeLN97AMYN1m25ZvKF/fAnaq DS7agmdysqlXc8w1lM5IYUrf4LG9EfLq01VJFe1+gncavD1YtvBiDnrvtcAhlqTUX6mb A5jA== X-Forwarded-Encrypted: i=1; AKwUvBxq5j2KLBFuPQiVqn+zE7QMHKjgvvLBTxZQpRo0SnJUdWIuKzpTLQ5cBbSudape97+3v55WD1Z0DOadgF0=@vger.kernel.org X-Gm-Message-State: AFuF++kqSJR234Uki5Xzm8ScLkjv7L9yfNu+puovC9Cxew0u0wodQIyX l6kDYK74pou/ddJMEe3jR0cOcmp4qqSgFu6XHFD5CfY3sjiYctQE011p X-Gm-Gg: AYBFou00oDkuxr5bciU1mcBzndUrbXqKaK8jS4+k3QV9MGD/AKZBkiB/umeh+jdyCaJ tmhr9vYh5tcDdMOeJ92UHofd1tHlxxDMq0g0bsQegZlJ06Y3UzvOgEZsAXfdgGecqYYRm/HAhLX EK+YPM8PFDnIq86Nq8yEzL2TsYoPK15yi+6AUo34HeFF/uPSSwSfANLzMgyxLhKV3AyP1iXOyPE RY0JWBRybI3pZy9aNN391J7nGWUxQ70flZP1g+KIxerK+hua1AhoApgbc4vutvtsZsef2eJMQkk nBxCzK9UOke6M9lcyKZxfl71JwQoNlWhgNA8PPSw2VDZwxikKQktc6AJHEcC+bXy++ydNsOZp9Q wzHWxy0P+jGY2Ats8Eq8Jd3blxB1R3Bdwzu35zip0v+Zp5FeRJ1dkvg5A+8G7itDqUGai7F1rof Id4Z+3xCq7m+kfkSarUQAmKjtnkXGIE0cmiAro8tql+TXGk8KQ0GqZuNHi1b5o+PDnRqxOH0Tfc Rn8B+BULJBe4etsOogG5UASW8UMnYjEOSEmHj156/eXWzOrNH+sg3FjieepaTEIlifi+biwe+oY PcOMISiYTg== X-Received: by 2002:a17:90b:58ef:b0:39e:194b:fb2b with SMTP id 98e67ed59e1d1-39e54d11af8mr15982682a91.22.1789964713657; Sun, 20 Sep 2026 21:25:13 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e6c5b3932sm11742139a91.13.2026.09.20.21.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 21:25:13 -0700 (PDT) From: Hui Peng To: Damien Le Moal , Christian Brauner , Jan Kara , Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH v2 2/6] qnx6: release buffer_head on error in qnx6_block_map() Date: Mon, 21 Sep 2026 04:25:07 +0000 Message-ID: <20260921042511.1473629-2-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260921042511.1473629-1-benquike@gmail.com> References: <20260919222556.3792829-1-benquike@gmail.com> <20260921042511.1473629-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In qnx6_block_map(), when qnx6_check_blockptr(ptr) fails ("qnx6: hit unused blockpointer.") inside the indirect block traversal loop, the buffer_head bh read by sb_bread() is not released before returning 0, leaving bh->b_count elevated and pinning the backing blockdev folio in memory. Call brelse(bh) on that error path before returning 0. Tested in QEMU against Linux 7.3.0-rc3 by mounting a crafted QNX6 image on /dev/loop0 with a file (di_filelevels = 1) whose indirect block (block 5) contains an unused block pointer (~0U), reading the file to trigger "qnx6: hit unused blockpointer.", and then flushing per-CPU bh_lrus and pagecache via /proc/sys/vm/drop_caches and POSIX_FADV_DONTNEED: on the unfixed kernel indirect block 5 remains pinned in bd_mapping (indirect_page5_leaked = 1), whereas on the fixed kernel indirect block 5 is released and evicted cleanly (indirect_page5_leaked = 0). Fixes: 5d026c724220 ("fs: initial qnx6fs addition") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v2: - Split the qnx6_block_map() buffer_head leak fix into its own patch (2/6) and remove Markdown formatting from the commit message, as requested by Damien Le Moal. fs/qnx6/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c index 13972c086673..9b624829520e 100644 --- a/fs/qnx6/inode.c +++ b/fs/qnx6/inode.c @@ -144,8 +144,10 @@ static unsigned qnx6_block_map(struct inode *inode, unsigned no) levelptr = (no >> bitdelta) & mask; ptr = ((__fs32 *)bh->b_data)[levelptr]; - if (!qnx6_check_blockptr(ptr)) + if (!qnx6_check_blockptr(ptr)) { + brelse(bh); return 0; + } block = qnx6_get_devblock(s, ptr); brelse(bh); -- 2.49.0