From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0BB494A0F for ; Mon, 21 Sep 2026 09:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789983265; cv=none; b=U5VZfM+kKIhcdePqRqBxaRwkAcZl26/gD7X6oiGbcxcvu/dyud7mjb9rqnzLmAEVQISUjQbYyBsyoFdg+zN9zmAGEe8nkHqaU1IuTSTKPWvsCZeyKf+6RD1vWdZdjlHg4Jc5Y8/6kjh+Jh+0qkQt6b+sIG36puhpAxhdcvQ37Jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789983265; c=relaxed/simple; bh=1VbwLbBIUh9b8IPRANpvWaAwiHFOkp76hogbIk7DodA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HCSkWEbKHGDkn7IWTOdCh9+vyDZY8J30pTKaly3YQVgrcU42s+qic1HVRkCviDXh8mLpSXt6IfgmndQsC79zYsG6e7C346j02hz/wlxdIl6uRuEqbUjv4MxeOSbBvqubhlT1CP4AxKsmzH1yoPgMFyHIfUnq9Hj7V3n71Qs3l/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ON2VBzMQ; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ON2VBzMQ" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48439feca17so2085942f8f.1 for ; Mon, 21 Sep 2026 02:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789983261; x=1790588061; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=vr1Hjh7AwrjiwGzdIsIwelbKhNuOiBeSErsKBn6SLyQ=; b=ON2VBzMQTVV65+OKnarhqU6gN1XErOuXXHstHNwRgbPQ/SI/MtlpmcJ4i6DbH62C0Q NV5BbAj0uJNJTuNYvwgibJLVUf54NMfi3Hdklv5rJ5gBth83TuO1epE6wSfoAYb40Ksv GUu4696HTzxvvBJKobe0W5pgUIkbfA3dGt9rwJYL342Xpq4ssBe+/fv4834wtJSUzmTR LZAsOASs6nu4nC3LUroqpIXx6FjdKNVdZWBuQPbCh+YRygoUeF3v/L48Ymlts4GMLYKX kuQX+1x7ioOWLtnWhGtwQ3YQd6sw16OThbaCyTqH9Mcy7lPvPPlRPWbwoMnvFCWOwx9X BNng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789983261; x=1790588061; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vr1Hjh7AwrjiwGzdIsIwelbKhNuOiBeSErsKBn6SLyQ=; b=MyKwm17CCwOBuZXQ/sYcgnOS7ktipXUQtuY8IGw+1mprUR7Z96cDRkSr0mcgDgjwXl 9AUW5cEqEhfENauEFizVSKBjkJ8nWvDUQENDKRu1yv2Vp95m4K4O14u3D8qT8piinl20 dwiCjyW4nDSoPXCoCz1aQEthuOb4yLnij4tlR1nkJ/pyZLZV2fRQddisjTOJ0KaE19WM wUbUTcCvuuwbF/Z5y9OXnhQsCfhhOIZSnTmj5Ift/ZqOalU3Cw94i4N8YhO6/rGmfSUE gt4PLNCeDx6n58HkShHUjCSNUg7jc1HCX9bYl/KsWkvSLusAOgDxsqkJ6AoB2BB8hJ1P Qlfw== X-Forwarded-Encrypted: i=1; AKwUvBzHZLpbb7t+nFoCXLl+2G314J+uZjlJijqNKzc+ux6v6Mto/2po5wwr2kedP8i27yOTwDSgARQZsqUiq+c=@vger.kernel.org X-Gm-Message-State: AFuF++nr95vcq770PXftScpzjRcOVh5Z0UzAoEiXJLIsCnjYHZn/Mlne rp+5dEU86FulnYB1WFmFYcKc6HKtctCgH4DBgnT5EU5O1Ejd/mGqGEhv X-Gm-Gg: AYBFou0Za93JZ5tRH5O/dnh2pbGHw7PZx4LPeMEMuN6EvU9WUNBD+1+0eFPiUFa+K0Z noJbbzD1TEeYio+pAcLV9jzCADqTEkrtZVo/60UoHg48u1GTSW4vVYMP0pvpKEMZUC/DQgYbvGe KwWA5tixPrScQZExAqxZHCjRwlDaz8HwKBnUvTWS0pGdcQfkW8SVlZ8kRi8Ysi9w70J7sWp8B63 fsAckyzkeMo0UKI9gNU5Nv7drbTv09JbtTjrr6H77oT8yaaW8FzQtKgJ2KNSl9had3OWIR9kJPN ZzujHfmx83uXTlr7PNn/s5n700kBNMeHksRMLuKTKmSD3J+407C+O1wzNx9TWiFx3fI0SYYuYbZ GvWYwL5lf/tDkwJ/t6oGQek/K9HE/zvR60IAowH5G3szfMPuLcqB7e53/z3dMwVVrdgvrFa2TN8 N9FYXAO2YgUfN6mrIzTs7cQ+UO7DIcQriI90G6ThKtjUU29ohiG9N31zIfNhwc9An9JqeVYeW6l VJfIOIwBOnyqU+A1xDx5T42oZJCr7XOX2+d7MHo5gX3KMvRtNlDMtdyZw== X-Received: by 2002:a05:6000:26cc:b0:487:77c:f704 with SMTP id ffacd0b85a97d-4871e3834f3mr15264648f8f.57.1789983260787; Mon, 21 Sep 2026 02:34:20 -0700 (PDT) Received: from gil-endeavour.hs.rfd0.com (bl10-2-111.dsl.telepac.pt. [85.243.2.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48724595289sm22906820f8f.29.2026.09.21.02.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 02:34:20 -0700 (PDT) From: Gilberto Conde To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: qcom: ipq5018: add missing pwm3 function on gpio13 Date: Mon, 21 Sep 2026 10:34:19 +0100 Message-ID: <20260921093419.2870168-1-gilbertorconde@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit GPIO13 supports the PWM3 function at mux select value 4, but the pingroup table leaves that slot empty and gpio13 is not listed in pwm3_groups. Selecting pwm3 on gpio13 is therefore rejected by the pinmux core: ipq5018-tlmm: invalid group "gpio13" for function "pwm3" The GL.iNet GL-X2000 drives its fan from PWM3 on this pin, and the vendor firmware muxes it with select value 4: gpio13 : out low func4 8mA no pull Add pwm3 to the fourth function slot of gpio13 and list gpio13 in pwm3_groups. With this the pin muxes as expected: pin 13 (GPIO_13): device 1941010.pwm function pwm3 group gpio13 Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") Signed-off-by: Gilberto Conde --- drivers/pinctrl/qcom/pinctrl-ipq5018.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c index 03cfba9534f..84392fe258c 100644 --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c @@ -563,7 +563,7 @@ static const char * const qdss_cti_trig_out_b1_groups[] = { }; static const char * const pwm3_groups[] = { - "gpio45", + "gpio45", "gpio13", }; static const char * const qdss_cti_trig_in_b1_groups[] = { @@ -689,7 +689,7 @@ static const struct msm_pingroup ipq5018_groups[] = { PINGROUP(10, blsp0_spi, blsp1_uart0, led0, gcc_plltest, qdss_tracedata_a, _, _, _, _), PINGROUP(11, blsp0_spi, blsp1_uart0, _, gcc_tlmm, qdss_tracedata_a, _, _, _, _), PINGROUP(12, blsp0_spi, blsp0_i2c, blsp1_uart0, _, gcc_plltest, qdss_tracedata_a, _, _, _), - PINGROUP(13, blsp0_spi, blsp0_i2c, blsp1_uart0, _, qdss_tracedata_a, _, _, _, _), + PINGROUP(13, blsp0_spi, blsp0_i2c, blsp1_uart0, pwm3, qdss_tracedata_a, _, _, _, _), PINGROUP(14, pcie0_clk, _, _, cri_trng0, qdss_tracedata_a, _, _, _, _), PINGROUP(15, _, _, cri_trng1, qdss_tracedata_a, _, _, _, _, _), PINGROUP(16, pcie0_wake, _, _, cri_trng, qdss_tracedata_a, _, _, _, _), -- 2.55.0