From: ryan.zhang@oss.nxp.com
To: boris.brezillon@collabora.com, steven.price@arm.com, liviu.dudau@arm.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Ryan Zhang <ryan.zhang@oss.nxp.com>
Subject: [PATCH] drm/panthor: dummy read to discard the stale first GPU_TIMESTAMP read
Date: Mon, 21 Sep 2026 18:29:57 +0800 [thread overview]
Message-ID: <20260921102957.1024029-1-ryan.zhang@oss.nxp.com> (raw)
From: Ryan Zhang <ryan.zhang@oss.nxp.com>
The first read of GPU_TIMESTAMP after the GPU has been idle can return a
value that lags the real counter, while a read issued immediately after is
accurate.
Userspace correlates this timestamp with the host clock, so a stale value
shows up as skew between the device and host time domains and makes
dEQP-VK.pipeline.monolithic.timestamp.calibrated.calibration_test fail
whenever a query happens to hit a large first-read error.
Signed-off-by: Ryan Zhang <ryan.zhang@oss.nxp.com>
---
drivers/gpu/drm/panthor/panthor_drv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 720bf889096d..956a147dc282 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -2,6 +2,7 @@
/* Copyright 2018 Marty E. Plummer <hanetzer@startmail.com> */
/* Copyright 2019 Linaro, Ltd., Rob Herring <robh@kernel.org> */
/* Copyright 2019 Collabora ltd. */
+/* Copyright 2026 NXP */
#ifdef CONFIG_ARM_ARCH_TIMER
#include <asm/arch_timer.h>
@@ -772,6 +773,10 @@ static int panthor_query_timestamp_info(struct panthor_device *ptdev,
#else
arg->timestamp_frequency = 0;
#endif
+
+ /* Dummy read to avoid stale values. */
+ gpu_read64_counter(ptdev, GPU_TIMESTAMP);
+
arg->current_timestamp = gpu_read64_counter(ptdev, GPU_TIMESTAMP);
arg->timestamp_offset = gpu_read64(ptdev, GPU_TIMESTAMP_OFFSET);
--
2.43.0
next reply other threads:[~2026-09-21 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 10:29 ryan.zhang [this message]
2026-09-21 16:36 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921102957.1024029-1-ryan.zhang@oss.nxp.com \
--to=ryan.zhang@oss.nxp.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®