mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Breno Leitao" <leitao@debian.org>,
	"Baoquan He" <baoquan.he@linux.dev>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Pasha Tatashin" <pasha.tatashin@soleen.com>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Dave Young" <ruirui.yang@linux.dev>,
	"Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	kexec@lists.infradead.org, kernel-team@meta.com
Subject: Re: [PATCH] vmcore: report the release of the crashed kernel
Date: Mon, 21 Sep 2026 10:52:05 +0000	[thread overview]
Message-ID: <20260921105205.9A5001F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-kdump_print-v1-1-e445fec3177c@debian.org>

> kdump runs in a very small environment and cut-down set of drivers, and
> it can die before the dump lands: it runs out of memory, a device hangs
> on reset, or a watchdog fires while the dump is still being written out.
> This happens about a single high digit percentage on most of big scale
> datacenters.
> 
> When that happens the only evidence left is what the capture kernel
> printed to the console, and that does not say which kernel crashed.
> 
> A fleet typically pins one kdump image and boots it after crashes from
> many different production kernels, and it is useful to understand what
> are the combination of crashed kernel panic and succesful kdump
> collection.
> 
> Whether the dump completes at all tends to depend on the kernel that
> died: memory pinned, devices in flight, dump size.
> 
> The release is already recorded.  crash_save_vmcoreinfo_init() puts
> OSRELEASE= in the VMCOREINFO note, and by the time vmcore_init() has run
> parse_crash_elf_headers() that note sits in elfnotes_buf.  Walk the notes
> for it and print:
> 
>   vmcore: dump is from kernel 7.3.0-rc3-next-20260917
> 
> Given this is cheap and useful, I think it is worth adding to vmcore, to
> improve kdump monitoring.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-kdump_print-v1-1-e445fec3177c@debian.org?part=1


      reply	other threads:[~2026-09-21 10:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 10:45 Breno Leitao
2026-09-21 10:52 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921105205.9A5001F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=kernel-team@meta.com \
    --cc=kexec@lists.infradead.org \
    --cc=leitao@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®