mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Quchaosheng <quchaosheng000406@163.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	John Stultz <jstultz@google.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Waiman Long <longman@redhat.com>, Boqun Feng <boqun@kernel.org>,
	Will Deacon <will@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] sched/proxy: allow SCHED_PROXY_EXEC with PREEMPT_RT
Date: Mon, 21 Sep 2026 14:57:40 +0200	[thread overview]
Message-ID: <20260921125740.vKjQ0Qtr@linutronix.de> (raw)
In-Reply-To: <178998790498.3308959.13462163523351109568@163.com>

On 2026-09-21 18:51:44 [+0800], Quchaosheng wrote:
> On 2026-09-21 12:09:21 [+0200], Sebastian Andrzej Siewior wrote:
> > Why exactly is this a good thing to do?
> 
> What the patch does is make a combination that the Kconfig itself already
> documents as broken ("Avoid some build failures w/ PREEMPT_RT until it can
> be fixed") compile again, and drop the RT stub in include/linux/sched.h
> whose parameter type did not match any caller. That is the whole of it.

Is there a build failure as of today or not?
The whole proxy exec thingy depends on !PREEMPT_RT, so there should be
no build failures.

> If that is not worth carrying, I would rather withdraw the patch than
> argue for it. Enabling a config that silently does nothing is a fair
> objection, and teaching the RT mutex to maintain blocked_on is the real
> work here.

I still fail to understand why we want it. It does nothing. The option
itself is document and once enabled CONFIG_SCHED_PROXY_EXEC does
something an !PREEMPT_RT and leads to a different behaviour if disabled.
But with your patch and PREEMPT_RT enabled there would be nothing that
CONFIG_SCHED_PROXY_EXEC does, would there be?

Sebastian

  reply	other threads:[~2026-09-21 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  8:15 Quchaosheng
2026-09-21 10:09 ` Sebastian Andrzej Siewior
2026-09-21 10:51   ` Quchaosheng
2026-09-21 12:57     ` Sebastian Andrzej Siewior [this message]
2026-09-22  7:06       ` [PATCH v2] " Quchaosheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921125740.vKjQ0Qtr@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=boqun@kernel.org \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=quchaosheng000406@163.com \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®