From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Liew Rui Yan <aethernet65535@gmail.com>,
Adrian Huang <adrianhuang0701@gmail.com>,
Karthikeyan KS <karthiproffesional@gmail.com>,
SJ Park <sj@kernel.org>, Xuewen Wang <wangxuewen@kylinos.cn>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 1/4] mm/damon/core: skip quota score setup when the quota is full
Date: Mon, 21 Sep 2026 08:15:43 -0700 [thread overview]
Message-ID: <20260921151547.78472-2-sj@kernel.org> (raw)
In-Reply-To: <20260921151547.78472-1-sj@kernel.org>
From: Liew Rui Yan <aethernet65535@gmail.com>
In damos_adjust_quota(), the quota could already be full.
In this situation, damos_adjust_quota() will still calculates
quota->min_score. However, this min_score will not be used in this
window, because in damon_do_apply_schemes(), damos_quota_is_full() will
always returns true, preventing the scheme from being applied to any
region.
Therefore, add a short circuit for 'esz < min_region_sz' schemes to
early return from damos_adjust_quota() before calculating min_score.
Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: SJ Park <sj@kernel.org>
---
Changes from v1
- v1: https://lore.kernel.org/20260913110407.32558-1-aethernet65535@gmail.com
- Collect R-b: from SJ.
- Rebase to the latest mm-new.
mm/damon/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 2258b72da7a7..98c767b9e6ef 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -3368,6 +3368,8 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s)
damos_trace_esz(c, s, quota);
}
+ if (damos_quota_is_full(quota, c->min_region_sz))
+ return;
if (!c->ops.get_scheme_score)
return;
--
2.47.3
next prev parent reply other threads:[~2026-09-21 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:15 [PATCH 0/4] mm/damon: improvements in efficiency, error handling, documents SJ Park
2026-09-21 15:15 ` SJ Park [this message]
2026-09-21 15:15 ` [PATCH 2/4] mm/damon/sysfs: propagate damon_call() error in turn_damon_on SJ Park
2026-09-21 15:15 ` [PATCH 3/4] mm/damon: fix typos in comments SJ Park
2026-09-21 15:15 ` [PATCH 4/4] mm/damon: document that a zero sample_interval is accepted SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921151547.78472-2-sj@kernel.org \
--to=sj@kernel.org \
--cc=adrianhuang0701@gmail.com \
--cc=aethernet65535@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=karthiproffesional@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangxuewen@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®