From: Jakub Kicinski <kuba@kernel.org>
To: Irlanki Sandeep <irlanki.s@samsung.com>,
edumazet@google.com, ncardwell@google.com
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, corbet@lwn.net, linux-kernel@vger.kernel.org,
lorenzo@google.com, maze@google.com, sporeba@google.com,
motomuman@google.com, srihari.k@samsung.com,
g.pokhra@samsung.com, r.kumawat@samsung.com,
raj.kumars@samsung.com, ts413.lee@samsung.com,
ramyashree.s@samsung.com, daeil2.hwang@samsung.com
Subject: Re: [PATCH net-next v4] tcp: add TCP_ECN and TCP_ECN_OPTION socket options
Date: Mon, 21 Sep 2026 15:26:04 -0700 [thread overview]
Message-ID: <20260921152604.2df7daaf@kernel.org> (raw)
In-Reply-To: <20260916050255.1379192-1-irlanki.s@samsung.com>
On Wed, 16 Sep 2026 10:32:55 +0530 Irlanki Sandeep wrote:
> Currently, ECN and Accurate ECN (AccECN) configurations in the Linux
> kernel are controlled globally via the net.ipv4.tcp_ecn and
> net.ipv4.tcp_ecn_option sysctl variables. This global approach lacks the
> granularity required for modern multi-application runtimes.
>
> In diverse network environments (such as mobile operating systems like
> Android), different applications route their traffic over distinct
> physical and virtual interfaces (cellular, Wi-Fi, VPNs, etc.). In the
> wild, certain legacy network paths or misconfigured middleboxes (such as
> routers, DPIs, or firewalls) are known to blackhole packets with ECN
> negotiation flags in the SYN, or silently drop packets containing AccECN
> option headers during active sessions.
My gut reaction is that we shouldn't be adding a setsockopt here.
This is a routing property, really, IIUC you're adding the setsockopt
because you want to use BPF, in which case isn't it better to add
a kfunc for this? Why go thru all the sockopt plumbing?
TCP maintainers, WDYT?
next prev parent reply other threads:[~2026-09-21 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260916050144epcas5p3f7d6a44556baabd24027af8f4bce7893@epcas5p3.samsung.com>
2026-09-16 5:02 ` Irlanki Sandeep
2026-09-21 22:26 ` Jakub Kicinski [this message]
2026-09-22 0:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921152604.2df7daaf@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daeil2.hwang@samsung.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=g.pokhra@samsung.com \
--cc=irlanki.s@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=motomuman@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r.kumawat@samsung.com \
--cc=raj.kumars@samsung.com \
--cc=ramyashree.s@samsung.com \
--cc=sporeba@google.com \
--cc=srihari.k@samsung.com \
--cc=ts413.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®