mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Krischer <florian.krischer@fkr.dev>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Lee Jones <lee@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Florian Krischer <florian.krischer@fkr.dev>
Subject: [PATCH v10 fixup 0/2] ASUS Transformer EC: SL101 keyboard event/response fixes
Date: Mon, 21 Sep 2026 19:52:35 +0200	[thread overview]
Message-ID: <20260921175234.3137985-1-florian.krischer@fkr.dev> (raw)
In-Reply-To: <20260721095233.420823-1-clamor95@gmail.com>

Hi,

I tested the v10 ASUS Transformer EC series on a physical ASUS Eee Pad
Slider SL101 while bringing up its built-in sliding keyboard.

The EC probes successfully as:

  Model         : ASUS-EP102-DOCK
  FW version    : SL101-0202
  Config format : ECFG-0001
  HW version    : PCBA-EP102

and the KBC child creates an AT Raw Set 2 serio keyboard, but v10-style
behavior does not complete atkbd initialization on the SL101.

Real-hardware tracing exposed three details:

1. The SL101 EC event window at 0x6a uses the 8-byte SMBus block reads
   found in ASUS's downstream driver. The generic 32-byte event read
   loses the keyboard command-response path on this device.

2. Keyboard command replies can be valid OBF-only packets without
   KEY/KBC set. Non-AUX, non-SMI/SCI OBF responses therefore need to be
   routed to keyboard serio0 so PS/2 ACKs reach atkbd.

3. The observed keyboard reset response is:

     03 09 fa aa

   where 03 counts the following status + payload bytes, 09 is status,
   fa is the PS/2 ACK and aa is BAT success. v9's data[0] - 1 payload
   count matches this framing. v10's data[0] - 2 drops the BAT byte.
   The fix keeps v10's upper-bound check while restoring data[0] - 1.

With these fixes and the SL101 EC DT node at 0x19/0x1b, Linux 6.18.45
boots through RAM-only kexec and the physical sliding keyboard works.

The two patches in this fixup set are intended to be folded into v10
patches 2/7 and 3/7 respectively, rather than merged as a competing
driver series.

The dependent Tegra SL101 DT patch is prepared separately and should be
submitted after/with the EC binding dependency.

Hardware:
  ASUS Eee Pad Slider SL101
  EC model ASUS-EP102-DOCK
  EC firmware SL101-0202

Validation:
  - physical keyboard PASS on real SL101 hardware
  - cleaned MFD and serio objects compile successfully
  - cleaned SL101 DTB compiles successfully
  - checkpatch: 0 errors, 0 warnings

Florian Krischer (2):
  mfd: asus-transformer-ec: use 8-byte event reads on SL101
  input: serio: asus-transformer-ec: fix keyboard response framing

 drivers/mfd/asus-transformer-ec.c             | 19 +++++++++++++++----
 drivers/input/serio/asus-transformer-ec-kbc.c | 16 +++++++++++-----
 2 files changed, 26 insertions(+), 9 deletions(-)

--

  parent reply	other threads:[~2026-09-21 17:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  9:52 [PATCH v10 0/7] mfd: Add support for Asus Transformer embedded controller Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 2/7] mfd: Add driver for ASUS Transformer embedded controller Svyatoslav Ryhel
2026-07-23  6:25   ` Uwe Kleine-König
2026-07-25 13:23     ` Svyatoslav Ryhel
2026-07-29 12:33       ` Uwe Kleine-König
2026-07-21  9:52 ` [PATCH v10 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Svyatoslav Ryhel
2026-08-19  9:20   ` Svyatoslav Ryhel
2026-09-06 17:22     ` Svyatoslav Ryhel
2026-09-21  7:34       ` Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 5/7] leds: Add driver for ASUS Transformer LEDs Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 6/7] power: supply: Add driver for ASUS Transformer battery Svyatoslav Ryhel
2026-07-21  9:52 ` [PATCH v10 7/7] power: supply: Add charger driver for Asus Transformers Svyatoslav Ryhel
2026-09-21 17:52 ` Florian Krischer [this message]
2026-09-21 17:52 ` [PATCH v10 fixup 1/2] mfd: asus-transformer-ec: use 8-byte event reads on SL101 Florian Krischer
2026-09-22  6:22   ` Svyatoslav Ryhel
2026-09-21 17:52 ` [PATCH v10 fixup 2/2] input: serio: asus-transformer-ec: fix keyboard response framing Florian Krischer
2026-09-22  6:25   ` Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921175234.3137985-1-florian.krischer@fkr.dev \
    --to=florian.krischer@fkr.dev \
    --cc=clamor95@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®