From: Jakub Kicinski <kuba@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: andrew+netdev@lunn.ch, arkadiusz.kubalewski@intel.com,
davem@davemloft.net, edumazet@google.com, jiri@resnulli.us,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
vadim.fedorenko@linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH] ptp: ocp: Fix dpll device reference leak in ptp_ocp_probe()
Date: Mon, 21 Sep 2026 18:23:48 -0700 [thread overview]
Message-ID: <20260921182348.3b7b60e3@kernel.org> (raw)
In-Reply-To: <20260917142337.2156652-1-vulab@iscas.ac.cn>
On Thu, 17 Sep 2026 14:23:37 +0000 Wentao Liang wrote:
> ptp_ocp_probe() takes a reference on the dpll device with
> dpll_device_get(), but jumps to the out label without dropping it when
> dpll_device_register() fails, so the reference leaks. Put it before
> returning.
AFAIR Sagi already fixes this in net-next
prev parent reply other threads:[~2026-09-22 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 14:23 Wentao Liang
2026-09-21 15:40 ` netdev-bot+sashiko
2026-09-22 1:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921182348.3b7b60e3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®