From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E4C4F93D9 for ; Mon, 21 Sep 2026 18:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790015464; cv=none; b=snqy1O8FALqN7Ygnv09uWi4r3o3lITidjp1H0C6YD+B6JhvJpmD7NJBCemiH2AVbzezIoAsw4Zkeymd2VN3vtrgYmMvzrYadXIgdV3KftMI4t063s93j1/vcoPmwTIh7PmIH5A9sjdoBduSdqjAw73ufM5R7bHezhK+MGb3lZ4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790015464; c=relaxed/simple; bh=TTaDVJxvd23TMPUHinu1BvIxlfSLR9eQbV5/IV4Szh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fcc+hvyklva1zAZguzN7FyeZqO41DqXKp0btacf5jVi/BE+q9JJ00A7TISdJ3WfLMnQAjnSM0SXOaV1hJMuNzB7h2EV+zpJ6ixjI5Gb/nQDjB9bREqymQ3L0S+OcUO5iIpPMRf5fts1oEfAbwMUZo5h5r8Wo7Qyd6Rnv+w0w8hY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pEyLUGer; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pEyLUGer" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-3a20f06cce6so1823611fa.1 for ; Mon, 21 Sep 2026 11:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790015461; x=1790620261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cK98X0r3BDRCEVKy2aZh2DV2AxA23p29nMm/EUx3t08=; b=pEyLUGera5obyGqCVkZxERmBe387Qro3tAC2anEbF8GrILs4AyahMo1GNp143DPK0Z t85itCgNDErCbn+10oPaJ7mGPMBDXs0dWtwsLRD0zjv6bL44/yYM7Jd6m8xV0PzMSFJ+ KTtJH0fT8JzUgwwS+1/ea8iln4BIbXZTY7rYMRxvAXvPdgIItucFjI9Sv+HNuuyaupZu 3/eBeeC6V0gtq2PTxofhLNoGrOUemCLIsHqMdYUbIApvsRSDDwEHR4DFapL2Owu7WEai BkZivpZkHVLnpXnh5loCFOvsuqWU1hPvI9qVG+Uwct6N+x9sDC11MbgafZhlVTU66Gai B0og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790015461; x=1790620261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cK98X0r3BDRCEVKy2aZh2DV2AxA23p29nMm/EUx3t08=; b=1g0nATGswlGkwB3uiIn7HOdqmYlKC24POGwiYUGUujXIXlElCP+ehuyLw2pPlKh/wI qckmlMrYY9yecGPESCY1STQcvn3iiIBK5aB9LGBIbuYE9HwB9o6FltaogoSFBkyER0X1 d4QMiVK46VvYup5958ou72kD/fQyvgZSMQOeuAtLT9Ai/ya+Ta2KDdZ0Z21sziFT8zZa +NbEdAdEcQFjOXCgIaCNSdA/SrGCnLvFCDdKzK2pL8Iom5YAFsW82KP3MGwwhU/P/IVR jWAvHvGr0LU/GSZW0ZIduJ4wcARi+e/BoYahci/Dbxb5ka7Ga9wO8hL52kHhr5KUKRt1 SUPQ== X-Forwarded-Encrypted: i=1; AKwUvBywTxnyL2x3WMOVzQr4sN3o9jEDqFigECOw8L06GgLJi9L11ZEbhhbA6OJgZttAG6Eu7pnbbkW2kmqbpeI=@vger.kernel.org X-Gm-Message-State: AFuF++nkUnBeI7WhOP2MPuFiUeJKZ1hu6wO8K10BbA1uxUFK4+ZEivPX AufkqHj8YqkAGCrlJw8z2ty8e8gx9iHSJMUF9/oJGvIV1a8lk4q1vgdu X-Gm-Gg: AYBFou00CHzTsrtHdrYBTR6mXb38ZONo+0ardhwDbj3u9/fwzh8Ni2thxLWfCQU1a3F DnC7HPavVGyy76iv847e7n3EBuvLPxsXEBvpF6PEXMGgEavHodVH2FQYrey9SHWSVrQTMnZ5hR2 2m9lfs8wC17k9XHErCFAnGkh1gyuHuGMY8onQXZiyWoudZHbgDZLZc49TTHoJ6gojO0JC16Lpgh kF38QDv4tQqfrRLdJ3MDmK8R2TGmpmrphuSCUkUlKqWbkyni+p9xWHz67SAkjJt/FFJlGBXHN/9 k52PEBycaDeuy2MDW3/kotIZaZrcB4sq3ngFafdrbeH129LD9O05KOgXWoSlyOOxxHi/8gRpeJC Xx3skwJ5XnaA/A5Gkh4aF08cRJc16zGYMQIvOr6/4WhuRnfd6Rrb3lknivTjvhgmtB37AHNGVfK oMmVuzqmobCys3HRIKTbKcrNijZQYNl7gXbRnhDodxp2Zk3DJMNPMWP7xq/65RO1ubpZpGwFobw 1TYVfPDxYO46PqNS8eI2VRozyEUk6+ssp+s4Lt5N2HAuRYx3UyGewRrAG/F63H49eFouoU= X-Received: by 2002:a05:651c:1474:b0:3a5:d31c:71a8 with SMTP id 38308e7fff4ca-3a624c8eb8bmr1246471fa.3.1790015460867; Mon, 21 Sep 2026 11:31:00 -0700 (PDT) Received: from yantra.. (dsl-trebng21-58c187-236.dhcp.inet.fi. [88.193.135.236]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a6075fcafbsm23739241fa.27.2026.09.21.11.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 11:31:00 -0700 (PDT) From: Rupesh Majhi To: Jonathan Cameron Cc: Andy Shevchenko , Bill Wendling , David Lechner , Eddie James , Joel Stanley , Justin Stitt , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v7 07/10] iio: pressure: dps310: read buffered samples from the hardware FIFO Date: Mon, 21 Sep 2026 21:30:59 +0300 Message-ID: <20260921183059.231935-1-zoone.rupert@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178992913316.706584.7705975324672941059.b4-review@b4> References: <20260918122517.377565-1-zoone.rupert@gmail.com> <20260918122517.377565-8-zoone.rupert@gmail.com> <178992913316.706584.7705975324672941059.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 20 Sep 2026 19:32:13 +0100 Jonathan Cameron wrote: > Given n is used in a couple of places, I'd keep the handling simple > by doing it as > for (i = 0, n = 0; i < DPS310_FIFO_DEPTH; i++, n++) Gone down to one counter, since n only ever tracked i here. Patch 9 adds a max_scans break after the store, where that form would lose the last entry read, so there the test moved to the top of the loop. > > + data->fifo_hold = NULL; > > Why clear fifo_hold? Nothing ever checks if it is NULL. Nothing does, so the function had nothing left to do and both callers just kfree() now. The clearing moved to the alloc side, otherwise a pressure session followed by a temperature-only one double frees. Rupesh