From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>
Cc: David Hildenbrand <david@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Teodorescu <fane@google.com>,
Dennis Tighe <dtighe@google.com>,
Sashiko Bot <sashiko-bot@kernel.org>,
Ackerley Tng <ackerleytng@google.com>,
Yan Zhao <yan.y.zhao@intel.com>
Subject: [PATCH v4 0/5] KVM: guest_memfd: Fix binding bugs
Date: Mon, 21 Sep 2026 14:06:11 -0700 [thread overview]
Message-ID: <20260921210616.1024168-1-seanjc@google.com> (raw)
Fix guest_memfd bugs related to binding to a memslot:
- Handle errors when inserting into guest_memfd's binding xarray, e.g. to
do the right thing on ENOMEM.
- Bind a memslot only once the memslot is fully prepared (because it becomes
reachable/visible once its inserted into gmem's bindings arraxy).
Patch 5 is a related cleanup to remove a superflous WRITE_ONCE() (unwinding
the slot update on insertion failure isn't an option if the slot is observable,
i.e. if the WRITE_ONCE() is actually necessary).
v4:
- Drop intermediate xar variable. [David, Ackerley]
- Collect reviews. [David, Ackerley]
- Restrict kvm_gmem_bind() to CREATE as calling kvm_arch_free_memslot() on
FLAGS_ONLY changes is unsafe, and doing the right thing for dirty bitmaps
is tricky for similar reasons. As a bonus, this eliminates the ugly
almost-duplicate code that David pointed out.
- Explain why KVM must deal with the unwind during bind(). [Ackerley]
v3:
- https://lore.kernel.org/all/20260904004342.3162959-1-seanjc@google.com
- Nullify bindings on error before dropping invalidat lock. [Sashiko x3]
v2:
- https://lore.kernel.org/all/20260902182020.2615443-1-seanjc@google.com
- Fix the binding-too-early bug. [Sashiko]
- Explicitly zero the bindings entry on failure to ensure there are no
partial entries. [Sashiko]
v1: https://lore.kernel.org/all/20260826165154.766699-2-seanjc@google.com
Sean Christopherson (5):
KVM: guest_memfd: Gracefully handle xarray errors when binding a
memslot
KVM: Use goto to handle errors during memslot preparation
KVM: Only bind memslot to guest_memfd instance for CREATE operations
KVM: guest_memfd: Establish memslot<=>guest_memfd bindings *after*
memslot is ready
KVM: guest_memfd: Drop superfluous WRITE_ONCE() when binding a memslot
virt/kvm/guest_memfd.c | 14 ++++++++--
virt/kvm/kvm_main.c | 62 ++++++++++++++++++++++--------------------
2 files changed, 44 insertions(+), 32 deletions(-)
base-commit: 70c944caf570fda2d79baa71435589a8db39f048
--
2.55.0.1082.g2b9226bbc0-goog
next reply other threads:[~2026-09-21 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 21:06 Sean Christopherson [this message]
2026-09-21 21:06 ` [PATCH v4 1/5] KVM: guest_memfd: Gracefully handle xarray errors when binding a memslot Sean Christopherson
2026-09-21 21:06 ` [PATCH v4 2/5] KVM: Use goto to handle errors during memslot preparation Sean Christopherson
2026-09-21 21:06 ` [PATCH v4 3/5] KVM: Only bind memslot to guest_memfd instance for CREATE operations Sean Christopherson
2026-09-21 21:06 ` [PATCH v4 4/5] KVM: guest_memfd: Establish memslot<=>guest_memfd bindings *after* memslot is ready Sean Christopherson
2026-09-21 21:06 ` [PATCH v4 5/5] KVM: guest_memfd: Drop superfluous WRITE_ONCE() when binding a memslot Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921210616.1024168-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=david@kernel.org \
--cc=dtighe@google.com \
--cc=fane@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®